Unify dropdown panel style — glass-2 + blur everywhere#247
Merged
Conversation
HydrationCard: both dropdowns used var(--bg-3) (opaque) instead of var(--glass-2), making them look flat compared to the favorites sort dropdown. NutritionCalculatorCard favorites picker: full rework to match the canonical glass dropdown pattern — glass-2 background, backdrop blur, 8px shadow, 12px border-radius, rounded items with proper hover/active colors, lucide ChevronDown with rotate-on-open animation replacing the raw inline SVG. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nyh5LqQbWh4zBKSDvZuk17
UP035: Sequence from collections.abc not typing UP007: Optional[X] → X | None union syntax (3 annotations) I001: sort imports (stdlib before third-party) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nyh5LqQbWh4zBKSDvZuk17
All four phases are complete. Remove stale phase-gate prose, phase-0 exit criteria, stub/implement lists, and [phase-X] commit prefix rule. Frontend pre-commit checks loosened: full suite (type-check + lint + test) only required before PRs or multi-file changes; type-check alone suffices for trivial single-file edits. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nyh5LqQbWh4zBKSDvZuk17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
var(--bg-3)(opaque/flat) — changed tovar(--glass-2)to match the canonical glass frosted styleglass-brightclass with explicit glass-2 + backdrop blur, replaced raw inline SVG chevron with lucideChevronDown+ rotate-on-open animation, replaced borderBottom item dividers with individually rounded items matching theoptionStylehover/color pattern from the favorites sort dropdownTest plan
pnpm test)pnpm type-check)🤖 Generated with Claude Code
https://claude.ai/code/session_01Nyh5LqQbWh4zBKSDvZuk17
Generated by Claude Code