Make dropdown menus opaque so background no longer shows through#248
Merged
Conversation
The favorites selector, food-search results, and hydration goal/glass dropdowns used --glass-2 (6% opaque white) and relied solely on backdrop-filter to hide what was behind them. Over bright card content and text, the underlying UI bled through. Add a --glass-popover token (near-opaque, theme-aware) and point the floating menus at it. The frosted blur, glass border, and shadow are unchanged, so the glass feel is preserved while the background is masked. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VDWtPAnqG2XzZB3rSnGb9J
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The favorites selector, food-search results (budget check), and hydration goal/glass-size dropdowns let the UI behind them bleed through — you could read card text and other content under the open menu.
Root cause: those menus used
background: var(--glass-2)(only 6% opaque white in dark mode) and leaned entirely onbackdrop-filter: blur(16px)to obscure what was behind. Blur alone can't mask bright content, so it showed through. The favorites-page sort dropdown looked fine only because it opens over the empty dark page area.Fix
--glass-popovertoken — near-opaque (rgba(16,24,44,0.94)dark /rgba(255,255,255,0.96)light) — for floating menus.The frosted blur, glass border, and drop shadow are unchanged, so the glass feel is preserved while the background is properly masked. The sort dropdown is intentionally left as-is (it was already perfect).
Verification
pnpm type-check✅pnpm lint— 0 errors (2 pre-existing warnings, untouched code)pnpm test— 114/114 passing ✅🤖 Generated with Claude Code
Generated by Claude Code