Skip to content

Refactor Optimization Components#16

Merged
d3mocide merged 1 commit intomainfrom
refactor-optimization-layer-5943167758003943548
Feb 27, 2026
Merged

Refactor Optimization Components#16
d3mocide merged 1 commit intomainfrom
refactor-optimization-layer-5943167758003943548

Conversation

@d3mocide
Copy link
Owner

This change refactors the OptimizationLayer and OptimizationResultsPanel components to improve maintainability and readability, as identified in the REFACTORING_REPORT.md.

  • OptimizationLayer: Was 517 lines, now decomposed into an orchestrator and 5 sub-components located in src/components/Map/UI/Optimization/.
  • OptimizationResultsPanel: Was 435 lines, now decomposed into sub-components.
  • Cleanup: Removed failing tests for calculateOkumuraHata which is no longer exported or used.

This completes "Phase 4 - Optimization Components" of the refactoring plan.


PR created automatically by Jules for task 5943167758003943548 started by @d3mocide

- Decomposed `OptimizationLayer.jsx` into smaller, focused sub-components:
  - `ScanningOverlay`
  - `OptimizationAlert`
  - `OptimizationSettingsPanel`
  - `CandidateMarkers`
  - `HeatmapOverlay`
- Decomposed `OptimizationResultsPanel.jsx` into:
  - `OptimizationHelp`
  - `ScoringWeights`
  - `ResultRow`
- Updated `REFACTORING_REPORT.md` to reflect these changes.
- Removed unused/failing tests for `calculateOkumuraHata`.

Co-authored-by: d3mocide <136547209+d3mocide@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@d3mocide d3mocide merged commit 76b0237 into main Feb 27, 2026
4 checks passed
@d3mocide d3mocide deleted the refactor-optimization-layer-5943167758003943548 branch February 27, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant