fix: Deduplicate lite DAO cards when full DAO exists#948
Open
fix: Deduplicate lite DAO cards when full DAO exists#948
Conversation
✅ Deploy Preview for tezos-homebase ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Filter out lite DAOs from the explorer list when they have a daoContract field matching a full (on-chain) DAO address, since the full DAO page already shows off-chain polls.
EightRice
force-pushed
the
fix/dedup-lite-dao-cards
branch
from
06448b3 to
2c17aea
Compare
When a user reaches an off-chain poll from a full DAO page, the "back to community" button now returns to the full DAO instead of the lite DAO community page.
The previous navigation fix didn't work because daoId was never passed from the full DAO proposals page through ProposalsList to ProposalTableRow, so route state.daoId was always undefined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
daoContractfield matching a full (on-chain) DAO addressChanges
src/services/services/types.ts— addeddaoContract?: stringtoDAOListItemandCommunityinterfacessrc/services/services/lite/lite-services.ts— passdaoContractthrough ingetLiteDAOsmappingsrc/services/services/dao/hooks/useAllDAOs.ts— filter lite DAOs whosedaoContractmatches a full DAO addressTest plan