Skip to content

change default values and add keyfreq-merge feature#21

Open
zimoun wants to merge 4 commits into
dacap:mainfrom
zimoun:keyfreq-merge
Open

change default values and add keyfreq-merge feature#21
zimoun wants to merge 4 commits into
dacap:mainfrom
zimoun:keyfreq-merge

Conversation

@zimoun

@zimoun zimoun commented May 16, 2016

Copy link
Copy Markdown
Contributor

The first commit fixes #7.
The second commit fixes #12, at least, it adds a new function able to merge two stats' files, following my proposal in the disucssion in #12.

It is just some tweaks around the existing functions keyfreq-table-load and keyfreq-table-save.
It should work on the fly, using the already in-place lock mechanism.

@dacap

dacap commented May 16, 2016

Copy link
Copy Markdown
Owner

Hi @zimoun, I'll take a look to this in these days.

Comment thread keyfreq.el
Else it uses this value of file to save TABLE, not considering the stats already store."

;; default argument
(setq load-previous-stats nil)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should load-previous-stats be defined in a (let...) block?

@zimoun

zimoun commented May 16, 2016

Copy link
Copy Markdown
Contributor Author

Added.

However, there is still two issues:

  • the first does not come from the keyfreq-merge feature. I am not able to run emacs -q -l keyfreq.el and I do not understand why. Maybe, I will open a special issue about that.
  • the second is more annoying: if keyfreq-mode is turn on, then the resulting file-C will contain the stats from the file-A and file-B, and also the stats of the current session. Which is unexepected. I am not sure to understand why...

I am working on it, to fix that. Otherwise, it does not make sense. Sorry for this partial PR.

@zimoun

zimoun commented May 16, 2016

Copy link
Copy Markdown
Contributor Author

My bad, sorry !

The second issue is know fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merging keyfreq data from multiple accounts Default value of keyfreq-file?

2 participants