Added a contrib section with a sample docker-compose file - #982
Conversation
dadoonet
left a comment
dadoonet
left a comment
There was a problem hiding this comment.
This is great. Thanks for sharing this.
I wonder if we could add a link from the documentation to this dir?
|
If you would tell me where you like to have it, I'll be happy to add a doc section as a new PR. |
|
Ideally you can add a new commit to this PR and add some content in https://github.com/dadoonet/fscrawler/blob/master/docs/source/user/tips.rst Thanks ! |
…er-compose-example files
|
committed. |
| networks: | ||
| - fscrawler_net | ||
|
|
||
| fscrawler: |
There was a problem hiding this comment.
That's something that I will modify once we merge the production of the Docker image in dockerhub. #820
There was a problem hiding this comment.
Yeah once it's in Dockerhub it'll be a lot easier. No build step needed at all for most people, some still like to build their own but most will just need the docker-compose file.
|
Doesn't work for me: the ENV lines duplicate SNAPSHOT as per... (pull request forthcoming/don't know if it's quicker to manually fix) diff --git a/contrib/docker-compose-example/Dockerfile-fscrawler b/contrib/docker-compose-example/Dockerfile-fscrawler ENV ES es7 RUN apk add --update |
|
Thanks. If you use 2.7 for VERSION, it'll work fine. this is in contrib, which means it is a template for you to copy and use. My thinking was that its for 'master' which means it'll always (it is an assumption) be a SNAPSHOT of the next version. |
3 participants
Fully tested complete docker-compose and Dockerfile to download and build three containers ES, KB, FSCrawler.
To enable, edit the docker-compose and change the path_to_files_to_scan to the actual path of files to be scanned. If need be, change the Dockerfile to match the version that you want to grab from github.