fix: symlink corePlugin to the path immich v3 reads#7
Merged
Conversation
Immich 3.0 resolves the core plugin at
${IMMICH_BUILD_DATA:-/build}/plugins/immich-plugin-core
(config.repository.js resourcePaths.corePlugin -> workflow-execution
service importFolder at boot), but the build only created the symlink
/build/corePlugin. /build/plugins/immich-plugin-core never existed, so
no plugin registered: /api/plugins and /api/plugins/methods returned [],
and every POST /api/workflows failed with
"Unknown method immich-plugin-core#...". All Workflows (screenshot
handling, smart albums, etc.) were non-functional.
The 07-02 "build for immich v3.0.0" change updated the COPY source to
upstream's new plugins/immich-plugin-core layout but left the runtime
symlink at the old /build/corePlugin name. Point the symlink at
/build/plugins/immich-plugin-core so importFolder finds the bundled
plugin. The wasm and @extism/extism runtime were already present and
correct; only the path was wrong.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ahze I just now see you fixed this here but the symlink was not updated:
8f1253f
Problem
The new Workflow builder (Utilities -> Workflows) introduced in Immich 3.0 is not displaying templates. It seems the plugin path changed and we weren't mounting it, looks like this on mine @ v3.0.1:
I did not find it mentioned in the official upgrade guide: https://immich.app/blog/v3-migration
Fix
Point the symlink at
/build/plugins/immich-plugin-coresoimportFolderfinds the bundled plugin. Thewasmand@extism/extismruntime were already present and correct, only the path was wrong.Environment
Tests
tests pending re: daemonless/dbuild#17
dbuild build --no-cachedbuild test