Skip to content

🛡️ Sentinel: [HIGH] Fix XSS in ResearchConsentForm #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daggerstuff wants to merge 4 commits into
base: staging
Choose a base branch
from
+66 −1
Open

🛡️ Sentinel: [HIGH] Fix XSS in ResearchConsentForm #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c33eaae
🛡️ Sentinel: [HIGH] Fix XSS vulnerability in ResearchConsentForm
google-labs-jules[bot] Apr 2, 2026
6908c35
🛡️ Sentinel: [HIGH] Fix XSS in ResearchConsentForm and fix failing CI…
google-labs-jules[bot] Apr 2, 2026
23b2628
Fix XSS vulnerability in ResearchConsentForm using isomorphic-dompurify
google-labs-jules[bot] Apr 3, 2026
8a6be17
Fix XSS vulnerability in ResearchConsentForm using isomorphic-dompurify
google-labs-jules[bot] Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@
"framer-motion": "^12.37.0",
"helmet": "^8.1.0",
"ioredis": "^5.10.1",
"isomorphic-dompurify": "^3.7.1",
"jigsawstack": "^0.4.3",
"jotai": "^2.18.1",
"jsonwebtoken": "^9.0.3",
Expand Down
63 changes: 63 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/components/consent/ResearchConsentForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { useState, useEffect } from 'react'

import { authClient } from '@/lib/auth-client'
import { consentService } from '@/lib/security/consent/ConsentService'
import DOMPurify from 'isomorphic-dompurify'
import type { UserConsentStatus } from '@/lib/security/consent/types'

interface ResearchConsentFormProps {
Expand Down Expand Up @@ -279,7 +280,7 @@ export function ResearchConsentForm({
<div className='bg-gray-50 border-gray-200 text-gray-700 mt-4 max-h-96 overflow-auto rounded-lg border p-4 text-sm'>
<div
dangerouslySetInnerHTML={{
__html: consentStatus.currentVersion.documentText,
__html: DOMPurify.sanitize(consentStatus.currentVersion.documentText),
}}
></div>
Comment on lines 281 to 285
Copy link
Copy Markdown

@charliecreates charliecreates bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOMPurify.sanitize() is a good fix, but the current usage leaves a couple of sharp edges:

  • Attack-surface reduction: DOMPurify defaults can allow SVG/MathML (historically higher-risk namespaces). For a HIGH-severity XSS fix, it’s better to explicitly restrict to the HTML profile.
  • Render-time work / branching: Sanitizing inline in render (and gating on typeof window) is harder to reason about and can be wasteful for large documents. If this ever renders in a non-browser environment, it will also silently render an empty document.

Consider computing the sanitized HTML once (memoized) and applying a stricter DOMPurify config.

Suggestion

Refactor to sanitize with an explicit HTML-only profile and memoize the result (and avoid silently blanking the document in non-window contexts):

import { useMemo } from 'react'

// ...inside component
const sanitizedDocumentText = useMemo(() => {
  return DOMPurify.sanitize(consentStatus.currentVersion.documentText, {
    USE_PROFILES: { html: true },
  })
}, [consentStatus.currentVersion.documentText])

// ...
<div dangerouslySetInnerHTML={{ __html: sanitizedDocumentText }} />

If you must support SSR/non-DOM execution, prefer an SSR-safe setup (e.g., dynamic import in useEffect, or an isomorphic DOMPurify wrapper) rather than ''.

Reply with "@CharlieHelps yes please" if you’d like me to add a commit with this refactor.

</div>
Expand Down
Loading