Conversation
Contributor
|
@arieljake can you help reviewing and testing this change? |
|
LGTM |
Merged
Contributor
|
I did a stress test as we discussed in #94 . It turns out that in both the old and new imlpementations of I ran the tests on node v9.2.0. |
Contributor
Author
|
Nice catch, thanks for running this. This indicates a bug in the old implementation as well, so it's a good chance to fix it. I'll work on this. |
64a1b87 to
cf48a25
Compare
|
I had a similar need and came across this PR while searching around. This is still being reviewed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces the
reducealgorithm which performs adfsbut processes the graph using an arbitrary function accumulator. pre-order and post-order are still supported. DFS has been rewritten using the newreducefunction.Fix #62