Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to debug some issues with my setup. Started by refining the type hints so that I can be a bit more confident about any changes.
There are a number of mypy errors remaining2 that need actual fixes in the code to resolve:
safely_get_json_valueawsiot)request_with_loggingcallsclean_dictionary_for_loggingon aMultiDictRestIot.is_clock_onreturning anintinstead ofbool__repr__()function return a dict, which is not allowedDifference (according to
mypy --txt-report2):Footnotes
other than the
from ... import ...calls. But the package doesn't have any import-time side-effects, AFAICT ↩with my mypy configuration that attempts to match the upstream homeassistant mypy config ↩ ↩2