Skip to content

feat: Add Apache RocketMQ health check#1634

Open
samtrion with Copilot wants to merge 2 commits into
mainfrom
copilot/add-health-check-apache-rocketmq
Open

feat: Add Apache RocketMQ health check#1634
samtrion with Copilot wants to merge 2 commits into
mainfrom
copilot/add-health-check-apache-rocketmq

Conversation

Copilot AI commented Mar 26, 2026

Copy link
Copy Markdown
Contributor
  • Create source project src/NetEvolve.HealthChecks.Apache.RocketMQ/
  • Add RocketMQ.Client v5.1.0 to Directory.Packages.props
  • Add project to HealthChecks.slnx solution file
  • Add project reference to unit test and integration test projects
  • Create unit tests in tests/NetEvolve.HealthChecks.Tests.Unit/Apache.RocketMQ/
  • Create integration tests in tests/NetEvolve.HealthChecks.Tests.Integration/Apache.RocketMQ/
  • Fix CSharpier formatting in RocketMQHealthCheck.cs (single-line dict init, single-line method calls, single-line builder chain)
  • Fix CSharpier formatting in RocketMQContainer.cs (single-line Endpoint property)
  • Add missing .testgroup file to integration test folder
Original prompt

This section details on the original issue you should resolve

<issue_title>NetEvolve.HealthChecks.Apache.RocketMQ</issue_title>
<issue_description>### Project Name

Apache.RocketMQ

Project Description

Health Check for Apache RocketMQ.

TestContainer Package Required?

No

TestContainer Package Name

Must be implemented based on Testcontainers

Required NuGet Dependencies

RocketMQ.Client

Validation Steps

  • Create project structure in src/NetEvolve.HealthChecks.<ProjectName>/
  • Add project to solution (dotnet sln HealthChecks.slnx add)
  • Add project reference to Test projects
  • Add required NuGet packages to Directory.Packages.props
  • Follow naming conventions from ADR decisions
  • Create README.md based on other projects
  • Create unit test folder in tests/NetEvolve.HealthChecks.Tests.Unit/<ProjectName>/
  • Create integration test folder in tests/NetEvolve.HealthChecks.Tests.Integration/<ProjectName>/
  • Add project reference to the solution file
  • Add project reference to existing test projects
  • Add TestContainer package if specified
  • Restore NuGet packages (dotnet restore HealthChecks.slnx)
  • Build the solution (dotnet build HealthChecks.slnx --no-restore)
  • Run tests for the new project (dotnet test HealthChecks.slnx --no-build)
  • Verify all tests pass successfully (>80% coverage recommended)
  • Comment on issue with build/test results
  • Create pull request linking to this issue

Additional Notes

https://github.com/apache/rocketmq-clients/tree/master/csharp
https://rocketmq.apache.org/docs/sdk/04csharp
</issue_description>

Comments on the Issue (you are @copilot in this section)

Custom agent used: C# Expert
An agent designed to assist with software development tasks for .NET projects.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI requested a review from samtrion March 26, 2026 09:13
Copilot stopped work on behalf of samtrion due to an error March 26, 2026 09:13
Copilot AI changed the title [WIP] Add health check for Apache RocketMQ feat: Add Apache RocketMQ health check Mar 26, 2026
@samtrion
samtrion force-pushed the copilot/add-health-check-apache-rocketmq branch from d9ab774 to 04a74c0 Compare March 26, 2026 16:33
@samtrion

Copy link
Copy Markdown
Contributor

@copilot fix the pipeline issues

Copilot AI commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

@copilot fix the pipeline issues

Fixed in 2ab3f3c. Two pipeline issues were resolved:

  1. CSharpier formatting (RocketMQHealthCheck.cs and RocketMQContainer.cs) — collapsed multi-line expressions to single lines as required by the formatter
  2. Missing .testgroup file — added tests/NetEvolve.HealthChecks.Tests.Integration/Apache.RocketMQ/.testgroup with Z00TestGroup (matching the pattern used by other integration test folders like Kafka and ActiveMQ)

@samtrion
samtrion marked this pull request as ready for review April 5, 2026 13:52
@samtrion
samtrion requested a review from a team as a code owner April 5, 2026 13:52
@samtrion
samtrion force-pushed the copilot/add-health-check-apache-rocketmq branch from 2ab3f3c to 0ee8db0 Compare April 16, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NetEvolve.HealthChecks.Apache.RocketMQ

2 participants