chore: remove Happening Now notifications#6092
Merged
idoshamun merged 2 commits intoMay 24, 2026
Merged
Conversation
Drop the MajorHeadlineAdded subscription hook, alerts banner, "Get real-time alerts" highlight card menu entry, in-app notification toggle, related feature flag, log events, and the dismiss-banner action. The HighlightCardOptions menu keeps the Pin/Disable placement controls. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ions The Megaphone icon was only mapped from the removed MajorHeadlineAdded notification. With only two static menu items left, inline the options array and drop the useMemo so the eslint-disable is no longer needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
idoshamun
deleted the
eng-1568-remove-support-of-happening-now-notifications
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the user-facing "Happening Now" notification subscription and settings. The Highlights display (the
majorHeadlinesquery,HighlightsPage, and the highlight cards in the feed) is intentionally kept — only the notification side is gone.Changes
useMajorHeadlinesSubscriptionhook andEnableHighlightsAlertsbanner (+ spec).InAppNotificationsTab: drop the "Happening Now" toggle and thefeatureMajorHeadlinesPushgate.HighlightCardOptions: drop the "Get real-time alerts" / "Turn off real-time alerts" menu item and the feature-flag gate; the kebab menu now only carries the Pin / Disable placement controls. Inlined the options array so theuseMemo+eslint-disableare gone.MajorHeadlineAddednotification type, theDismissedMajorHeadlinesAlertsBanneraction, thefeatureMajorHeadlinesPushflag, relatedLogEvent/NotificationPromptSourceentries, and the now-deadMegaphoneicon mapping.Key decisions
/highlightspage) is preserved — the ticket only removes notifications.HighlightCardOptionsmenu stays even though it only has two items, since Pin/Disable are useful on their own and match the pre-existing UX.Test plan
pnpm --filter shared linton changed files (clean)node ./scripts/typecheck-strict-changed.js(clean)jest src/components/cards/highlight/ src/components/notifications/ src/components/highlights/ src/components/sidebar/Sidebar.spec.tsx src/components/quest/QuestButton.spec.tsx src/components/Feed.spec.tsx— 122 passingCloses ENG-1568
Created by Huginn 🐦⬛
Preview domain
https://eng-1568-remove-support-of-happe.preview.app.daily.dev