fix: fall back to shared post title in ShareBar#6093
Merged
idoshamun merged 2 commits intoMay 24, 2026
Merged
Conversation
For shared posts with no title, the post sidebar share buttons were passing an undefined description to Twitter/social share links. Fall back to the referenced post's title so the share text is populated. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Reference the test-local post in both setup and assertion so the test reads top-to-bottom without jumping back to the fixture. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
idoshamun
deleted the
eng-1532-feedback-bug-report-description-is-null-when-sharing-on
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For shared posts with no title (commentary), the post sidebar's share buttons were passing an undefined description to the Twitter/X share link (and other social providers). Now we fall back to the referenced post's title, matching the existing
post.title || post.sharedPost?.titlepattern used inPostItemCard, the squad moderation components, andPostSEOSchema.Changes
ShareBar.tsx:text: post?.title→text: post?.title || post?.sharedPost?.titleShareBar.spec.tsx: added a regression test that mounts a shared post withtitle: undefinedand asserts the Twitter share link is built withsharedPost.titleTest plan
pnpm --filter @dailydotdev/shared exec eslinton changed filesnode scripts/typecheck-strict-changed.jspnpm --filter @dailydotdev/shared exec jest src/components/ShareBar.spec.tsx(7/7 pass)Closes ENG-1532
Created by Huginn 🐦⬛
Preview domain
https://eng-1532-feedback-bug-report-des.preview.app.daily.dev