fix(header): keep profile-completion dot visible inside the stats pill#6108
Merged
Conversation
The stats pill uses overflow-hidden so the hover backgrounds round cleanly at the pill's rounded-12 corners. That same clip was hiding the bottom half of the yellow profile-completion indicator, which ProfilePictureWithIndicator positions half outside the avatar via translate. Render ProfilePicture directly inside the combined profile Button, and lift the indicator dot out to a sibling of the pill anchored to a relative outer wrapper. Positioned at right-[31px] -bottom-1, the dot lands at the same visual spot as the avatar's bottom-left corner without being affected by the pill's overflow clip. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
In compact mode the streak's WarningIcon was rendered as a flex sibling of the streak icon inside a width-constrained IconWrapper, so it overflowed the wrapper and appeared on top of the streak number. Wrap the streak icon in a relative slot in compact mode and render the WarningIcon as an absolute size-4 badge anchored at the streak icon's bottom-left corner — mirroring how the profile-completion dot sits on the avatar. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #6106. The stats pill uses `overflow-hidden` so the hover backgrounds round cleanly at the pill's `rounded-12` corners. That same clip was hiding the bottom half of the yellow profile-completion indicator that `ProfilePictureWithIndicator` positions half outside the avatar via `translate-y-1/2`.
This PR:
Reported via in-app feedback (Linear).
Test plan
🤖 Generated with Claude Code
Preview domain
https://claude-fix-profile-indicator-cli.preview.app.daily.dev