Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/shared/src/components/cards/squad/SquadList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const SquadList = ({
return (
<div
{...attrs}
className="relative flex flex-row items-center gap-4"
className="group/squad-row relative flex flex-row items-center gap-4"
ref={ad ? ref : undefined}
>
<Link
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export const NetworkSection = ({
),
title: name,
path: `${webappUrl}squads/${handle}`,
itemClassName: 'group/squad-row',
rightIcon: () => <SquadFavoriteButton squad={squad} />,
};
}) ?? [];
Expand Down
75 changes: 75 additions & 0 deletions packages/shared/src/components/squads/SquadFavoriteButton.spec.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
import React from 'react';
import { render, screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { SquadFavoriteButton } from './SquadFavoriteButton';
import { useSquadFavorite } from '../../hooks/squads/useSquadFavorite';
import { generateTestSquad } from '../../../__tests__/fixture/squads';
import type { Squad } from '../../graphql/sources';

jest.mock('../../hooks/squads/useSquadFavorite', () => ({
useSquadFavorite: jest.fn(),
}));

const toggleFavorite = jest.fn();

const renderButton = (overrides: Partial<Squad> = {}) =>
render(<SquadFavoriteButton squad={generateTestSquad(overrides)} />);

describe('SquadFavoriteButton', () => {
beforeEach(() => {
jest.clearAllMocks();
jest.mocked(useSquadFavorite).mockReturnValue({
toggleFavorite,
isPending: false,
});
});

it('renders an unpressed star with the correct aria label when not favorited', () => {
renderButton({ favoritedAt: null });

const button = screen.getByRole('button', { name: 'Favorite squad' });
expect(button).toBeInTheDocument();
expect(button).toHaveAttribute('aria-pressed', 'false');
});

it('renders a pressed star with the unfavorite aria label when favorited', () => {
renderButton({ favoritedAt: '2025-01-01T00:00:00.000Z' });

const button = screen.getByRole('button', { name: 'Unfavorite squad' });
expect(button).toBeInTheDocument();
expect(button).toHaveAttribute('aria-pressed', 'true');
});

it('calls toggleFavorite with the squad when clicked', async () => {
const squad = generateTestSquad({ favoritedAt: null });
render(<SquadFavoriteButton squad={squad} />);

await userEvent.click(
screen.getByRole('button', { name: 'Favorite squad' }),
);

expect(toggleFavorite).toHaveBeenCalledWith(squad);
});

it('applies hover-reveal classes when the squad is not favorited', () => {
renderButton({ favoritedAt: null });

const button = screen.getByRole('button', { name: 'Favorite squad' });
expect(button).toHaveClass('laptop:opacity-0');
expect(button).toHaveClass('laptop:group-hover/squad-row:opacity-100');
expect(button).toHaveClass(
'laptop:group-focus-within/squad-row:opacity-100',
);
});

it('does not apply hover-reveal classes when the squad is already favorited', () => {
renderButton({ favoritedAt: '2025-01-01T00:00:00.000Z' });

const button = screen.getByRole('button', { name: 'Unfavorite squad' });
expect(button).not.toHaveClass('laptop:opacity-0');
expect(button).not.toHaveClass('laptop:group-hover/squad-row:opacity-100');
expect(button).not.toHaveClass(
'laptop:group-focus-within/squad-row:opacity-100',
);
});
});
2 changes: 2 additions & 0 deletions packages/shared/src/components/squads/SquadFavoriteButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ export const SquadFavoriteButton = ({
onClick={onClick}
className={classNames(
'relative z-1 flex items-center justify-center disabled:opacity-50',
!isFavorited &&
'laptop:opacity-0 laptop:transition-opacity laptop:group-focus-within/squad-row:opacity-100 laptop:group-hover/squad-row:opacity-100',
className,
)}
>
Expand Down
Loading