feat: remove new indicator from quest button#6114
Merged
AmarTrebinjac merged 2 commits intoMay 29, 2026
Merged
Conversation
Drop the hasNewQuestRotations-driven "new" bubble and the supporting frontend plumbing (mark-viewed mutation, account-age check, dashboard field). The backend schema is left in place and can be cleaned up in a follow-up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Drop the misleading hasNewQuestRotations:true spread in the bubble guard test; the field no longer exists, so asserting the bubble never renders against the default dashboard is enough. - Remove orphaned QuestRotationUpdate / QuestRotationUpdateData types that only existed to describe the deleted rotation-viewed flow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AmarTrebinjac
deleted the
eng-1597-remove-new-notificataion-on-quest-button
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasNewQuestRotations-driven "new" bubble from the quest button — the indicator no longer renders regardless of rotation state.useMarkQuestRotationsViewedhook + mutation, the 24-hour account-age suppression, and thehasNewQuestRotationsselection on the dashboard query.QUEST_ROTATION_UPDATE_SUBSCRIPTIONin place — it still refreshes the dashboard when rotations change, which is independently useful for surfacing fresh quests inside the dropdown.Key decisions
markQuestRotationsViewedmutation indaily-apiare left intact; a follow-up can remove them once nothing consumes the field.quest-button-new-indicatornever renders.Test plan
node ./scripts/typecheck-strict-changed.js)QuestButton.spec.tsx(23/23) andgameCenter.spec.ts(5/5) passCloses ENG-1597
Created by Huginn 🐦⬛
Preview domain
https://eng-1597-remove-new-notificataio.preview.app.daily.dev