Fix Roman numeral handling #528#540
Closed
moritz-gross wants to merge 1 commit into
Closed
Conversation
… add regression tests. (daisy#528)
NSoiffer
added a commit
that referenced
this pull request
Jun 1, 2026
Fixes #528. Includes the tests in the PR.
Collaborator
|
The real problem was a bad Rule that missed testing for chemistry. The roman numerals shouldn't be spoken, but some braille codes handle them in a special way (typically modifying the capitalization rules). I've included the tests you wrong in a separate commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the examples from the issue as regression tests.
Generally it looks like the detection of Roman numerals should be more conservative.
tbh I'm not really happy how this seems to be handled within MathML, but I guess we have to work with what we're given.
The tests should be ready to go as they are, but I doubt the code changes are ideal.
I only just learned that there's an intent attribute, and that chemistry apparently uses roman numerals for oxidation numbers?!? (well at least that's one way to get some more general knowledge, yesterday I learned what a katal is)