fix --rules-dir in mathml2text CLI#543
Conversation
* Added `resolve_rules_dir` function to handle `--rules-dir` resolution. * Updated logging to display the resolved rules directory. * Added tests ensuring correct behavior for explicit `--rules-dir` usage, default rules-dir fallback, and invalid rules-dir handling.
|
@NSoiffer asked me to take a look. The actual |
|
@masonium: Should I close this without merging? |
|
I think the comments by @masonium make sense, I just forgot that this PR existed. I'll do it in the coming days. side note: I'm unsure how I just update this branch. 99% sure I clicked "Sync fork" in my repo, so https://github.com/moritz-gross/MathCAT should've been affected. or what am I missing? |
|
@masonium is this what you had in mind? so far I've not written any fixtures for CLI or file system interaction, particularly in Rust. Is the failure of linting in |
While testing out the mathml2text CLI, I noticed that
--rules-dirseems to not actually be used.For example, the following shouldn't work right?
cargo run --bin mathml2text -- --rules-dir /some/other/rulesRegarding the integration tests, I don't really know what I'm doing there.