fix: preserve standalone comments in import blocks#244
Open
yammesicka wants to merge 1 commit into
Open
Conversation
yammesicka
force-pushed
the
fix/preserve-standalone-import-comments
branch
2 times, most recently
from
a8b836d to
b8565a7
Compare
Fixes daixiang0#135. GCI was removing standalone line comments (e.g. // +kubebuilder:scaffold:imports) from import blocks. This change scans the region between the last import and the closing ) for standalone // line comments and preserves them in the output. Standalone /* */ block comments are not preserved because go/format merges them with the closing ), producing non-idempotent output. Signed-off-by: yammesicka <yammesicka@gmail.com>
yammesicka
force-pushed
the
fix/preserve-standalone-import-comments
branch
from
b8565a7 to
74d9006
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #135.
GCI was removing standalone line comments (e.g.
// +kubebuilder:scaffold:imports) from import blocks when reformatting imports.Limitations
Only
//line comments are preserved. Standalone/* */block comments as the last element before)are not supported becausego/formatmerges them with the closing), producing non-idempotent output.