ghostel-kitty: ensure scale of kitty images to avoid cropping#532
Merged
Conversation
Collaborator
|
Thanks for the PR. The kitty graphics support needs a lot of love, but this at least fixes the immediate issue. My plan is to rewrite the code soon. |
Author
|
I will continue to keep an eye out and test various bits and pieces around this. it's very exciting! But I mostly use these things on my windows machine, and it remains to be seen if I can make zig actually compile. ($corp laptop acts like it has seen a ghost whenever something ends in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emacs tries to match the height of kitty images to the surrounding text is scale isn't set due to
create-image:without the patch:

with the patch:

this is using ghostel v0.43.0 on windows.