fix: use Object.defineProperty for navigator polyfill#94
Open
fix: use Object.defineProperty for navigator polyfill#94
Conversation
Replace direct global.navigator assignment with Object.defineProperty on globalThis to handle environments where navigator is read-only.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the global navigator polyfill in the CLI inject script to use
Object.definePropertyonglobalThisinstead of direct assignment. This resolves issues in environments wherenavigatoris a read-only property.Resolves #93
Changes
global.navigatorassignment withObject.definePropertyonglobalThis(d316f28)writableandconfigurabletotruefor compatibilityglobalThisinstead ofglobalfor the navigator referenceTesting Checklist
navigatorwas previously read-only