Conversation
added 10 commits
February 11, 2026 10:32
- Add sysml-v2-grammar as git submodule (daltskin/sysml-v2-grammar) - Remove scripts/grammar/ (now in submodule) - Update Makefile to reference submodule paths - Update package.json grammar:from-spec script - Add submodules: true to release.yml checkout step The grammar generator, config, KEBNF parser, and utility scripts now live in the dedicated sysml-v2-grammar repository with their own CI (generate.yml) and upstream watcher (watch-upstream.yml) workflows.
- Update grammar file headers to reference npm run grammar:from-spec - Add submodules: true to CI workflow checkout step - All linting passes (0 errors) - All 16 sample files parse with 0 errors - All 192 view tests pass (137 pass, 55 warnings, 0 failures)
- Remove sysml-v2-grammar git submodule - Add npm run grammar:download — fetches .g4 files from GitHub release - grammar:full now chains download + ANTLR compile - Makefile grammar target uses gh release download - Remove submodules: true from CI and release workflows - No Python/pip dependency needed for grammar updates
The visualization/renderers/ subtree and supporting types were never wired into visualizationPanel.ts (which handles all rendering inline). Replaced dynamic import of getRendererDefinitions() in extension.ts with an inline view definitions array. Removed source files: 10 renderers, 3 common utilities, 6 type modules Removed test files: 6 tests that only tested the orphaned modules Lint warnings: 95 → 88 (0 errors)
…ality - Removed the `debug-elk` command from the Makefile help section and its implementation. - Updated the `grammar-clean` target in the Makefile to provide clearer output and remove specific grammar files. - Enhanced the README commands section with additional commands and descriptions for better user guidance. - Updated context menu instructions in the README for visualizing SysML files. - Changed comments in grammar files to reflect the new command for updating grammar. - Simplified the `antlr:generate` script in package.json by removing the unnecessary token copy step.
refactor: clean up whitespace in test-all-samples.js for improved readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make grammar/npm run grammar:downloadSysMLv2.g4toSysMLv2Parser.g4(aligned with upstream repo)antlr:copy-tokensbuild step — tokens file now included in grammar releasemake debug-elktarget — usenpm run debug:elkdirectly if needed