Ix with regen#1
Draft
dalyw wants to merge 22 commits into
Draft
Conversation
Distinguished N removal and NH4 removal in electroNP_ZO
…t to incorporate regenerant dissociation in regen stream
…itialization and target ion concentration in regen stream
- Troubleshooting mass balance (WIP - getting negative Na+ concentration in spent regen stream)
Adding diagnostics
Specifying mass OR molar basis for concentrations in ion_exchange_0D Debugging in progress for initialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR to see what PR to watertap main will eventually look like