Bsm generic np for comparison#2
Draft
dalyw wants to merge 14 commits into
Draft
Conversation
…ack changes - unit model - flowsheet - costing model
- mass vs mole basis for specifying flows. (will use moles for IX, mass for this flowsheet) - separately breaking out removal factors and electricity consumption for "S_PO4", "S_NH4", "S_NO3", "S_NO2" and updating functions like electricity_consumption accordingly - adding molar mass parameters (there might be a better way to svae this) Adding to genericNP.py costing - ammonia_recovery_value - cost_ammonia_flow argument and equation BSM2_genericNP_no_bioP.py - adding costing method (still debugging infeasibility errors) - debugging print statements (temporary) - specifying mass basis for genericNP - adding parameter sweep on both NH4 removal and P removal, and helper functions (build_model, build outputs, run_analysis, etc) Also adding create_dash_app function for visualization
Adding costing after initialization similar to BSM2.py. Updating multi_sweep.py to match Making full WWTP unit model capex OPTIONAL in BSM2_genericNP_no_bioP.py Applying recovery value of N and P products Allowing either nh4_removal or n to p ratio for n removal fraction Debugging multiprocessing in multi_sweep.py
WIP debuggin multi-N-limit sweep with optimize_design.py
dalyw
pushed a commit
that referenced
this pull request
May 3, 2026
* add python 3.12 and 3.13 to workflow as a test * add user mode tests for 3.12 and 3.13 * Update BSM2-P tests * Update numerical issues test * Revert BSM2-P test changes * Attempting to fix w/o taking the log of the condition number * Attempt #2 w/o taking the log of the condition number --------- Co-authored-by: Sufi Kaur <sufikaur@lbl.gov> Co-authored-by: MarcusHolly <marcus.holly@keylogic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: