Reopened- GUI Configuration: Created config.schema.json#13
Open
AppleTechy wants to merge 3 commits into
Open
Conversation
Created config.schema.json for all configuration values besides 'excluded_attributes' and `excluded_capabilities`. A by product of the UI configuration is that it automatically inputs into the config.json the boolean values even if they are not different than the defaults the plugin sets.
Moved the changelog from the readme into its own file. This is more inline with what the expectations of Homebridge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created config.schema.json which would allow configuration via GUI in Config-UI-X. Also fixed the license listed in the package.json currently throws an SPDX License error on install due to incorrect ID. All configuration settings can be set via the GUI except
excluded_attributesandexcluded_capabilities. If those were to be configured via GUI it would require a change in how users configure them in the config.json. See here for necessary changes . It would be possible put this would break backwards compatibility with previousconfig.jsonversion. Another breaking change that would make GUI configuration simpler would be reworking how the boolean values in theconfig.jsonwork. If GUI configuration is used boolean values will be put intoconfig.jsonno matter if they are the same as the defaults the plugin uses.I also moved the changelog from the readme to a separate file. This makes the readme a little bit more readable and this way the changelog can be read in to Homebridge UI.
This PR has no breaking changes.
These breaking changes are just being discussed for possibly another PR later to allow better configuration via GUI.
RE: Dependencies from last PR, Winston log rotate has been deprecate.Tried switching to https://github.com/winstonjs/winston-daily-rotate-file however that seemed to break some stuff. I think it would be best to remove the external log and integrate solely into Homebridge's log rather than generating an extraneous log file.