avoid silently truncating the offset#75
Open
oconnor663 wants to merge 2 commits intodanburkert:masterfrom
Open
avoid silently truncating the offset#75oconnor663 wants to merge 2 commits intodanburkert:masterfrom
oconnor663 wants to merge 2 commits intodanburkert:masterfrom
Conversation
This should address one of the concerns that came up in danburkert#65.
This avoids casting negative numbers into an unsigned type.
Owner
|
I expected that the fix to this would be to use |
Author
|
That definitely sounds like the better fix where it's possible, but I don't know how wide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address one of the concerns that came up in #65.
I'm not sure exactly what test I should add for this case. Please advise :)