Switch to use /rdf/ renderer for purl obo urls#1772
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1772 +/- ##
=======================================
Coverage 75.07% 75.08%
=======================================
Files 84 84
Lines 11910 11910
=======================================
+ Hits 8942 8943 +1
+ Misses 2968 2967 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…DF representation on Ontobee obolibrary changed the redirection target of a PURLs identifying an entity on NCBITaxon from an RDF representation on Ontobee to an HTML representation on the NIH official site as of OBOFoundry/purl.obolibrary.org#1066. Our logic requires the representations to be RDF, so we are redirecting the affected PURLs to the corresponding RDF representation manually.
There was a problem hiding this comment.
Pull request overview
This PR modifies the parse_purlobourl function to use a different endpoint when fetching RDF content for NCBITaxon URLs from Ontobee. Instead of directly requesting the purl.obolibrary.org URL, the code now constructs a specific RDF endpoint URL for NCBITaxon ontology entries.
Key changes:
- Added conditional logic to detect NCBITaxon URLs and route them to the Ontobee RDF renderer endpoint
- Non-NCBITaxon URLs continue to use the original direct request approach
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@yarikoptic I can't request a review from you because you opened this PR. Please take a look. I modified the solution so that the value of |
|
🚀 PR was released in |
2 participants
TODOs
It is not a complete solution since test fails so there is more to it I guess (please finish up or redo @candleindark )
Closes Failures in tests with marker
obolibrary#1769