Skip to content

feat: restore modifies_hooks (supersedes reverted PR #1)#3

Closed
dango85 wants to merge 1 commit intomainfrom
feat/restore-modifies-hooks
Closed

feat: restore modifies_hooks (supersedes reverted PR #1)#3
dango85 wants to merge 1 commit intomainfrom
feat/restore-modifies-hooks

Conversation

@dango85
Copy link
Copy Markdown
Owner

@dango85 dango85 commented Apr 14, 2026

Summary

GitHub does not allow reopening a merged PR, so this is a new PR that restores the same behavior as #1 (reverted on main in 1.2.1).

  • Re-adds modifies_hooks in extension.yml to disable the git extension's before_specify -> speckit.git.feature hook on install (with consent)
  • Restores README "Hook overrides" + consent UX documentation
  • Bumps version to 1.2.2 and documents in CHANGELOG

Depends on

Test plan

  • Manifest still validates with lifecycle.post_install + modifies_hooks
  • bash tests/test-post-install.sh and bash tests/test-create-worktree.sh

Made with Cursor

Re-adds modifies_hooks to disable git before_specify on install with consent.
Bumps extension to 1.2.2. Supersedes the 1.2.1 revert for users who want automatic hook coordination.

Requires: github/spec-kit#2209
Made-with: Cursor
@dango85
Copy link
Copy Markdown
Owner Author

dango85 commented Apr 14, 2026

Closing: aligns with spec-kit maintainer guidance — we are not shipping cross-extension hook changes (modifies_hooks). Parallel worktrees use explicit .specify/extensions.yml + git worktree add -b; opinionated flows belong in a preset. See README / CONTRIBUTING on main (e.g. PR #5).

@dango85 dango85 closed this Apr 14, 2026
@dango85 dango85 deleted the feat/restore-modifies-hooks branch April 14, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant