feat: restore modifies_hooks (supersedes reverted PR #1)#3
Closed
feat: restore modifies_hooks (supersedes reverted PR #1)#3
Conversation
Re-adds modifies_hooks to disable git before_specify on install with consent. Bumps extension to 1.2.2. Supersedes the 1.2.1 revert for users who want automatic hook coordination. Requires: github/spec-kit#2209 Made-with: Cursor
Owner
Author
|
Closing: aligns with spec-kit maintainer guidance — we are not shipping cross-extension hook changes ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub does not allow reopening a merged PR, so this is a new PR that restores the same behavior as #1 (reverted on
mainin 1.2.1).modifies_hooksinextension.ymlto disable the git extension'sbefore_specify -> speckit.git.featurehook on install (with consent)Depends on
modifies_hookssupport in Spec KitTest plan
lifecycle.post_install+modifies_hooksbash tests/test-post-install.shandbash tests/test-create-worktree.shMade with Cursor