Create a recompress library to embedding in other sources#76
Open
pope wants to merge 13 commits intodanielgtaylor:masterfrom
Open
Create a recompress library to embedding in other sources#76pope wants to merge 13 commits intodanielgtaylor:masterfrom
pope wants to merge 13 commits intodanielgtaylor:masterfrom
Conversation
This will allow other code to use the same jpeg-recompress logic.
Author
|
BTW, the broken build is with just the GCC part and had an error message of "An error occurred while generating the build script.". So I think the build is OK. I'm not sure how to re-run the CI build again to be sure. |
Author
|
Ping. Any thoughts on this? |
Author
|
Re-ping :) |
Author
|
FYI - this branch now includes #85 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request splits out the recompression logic in
jpeg-recompress.cinto its own source file.The reason I want to do this is I'm interested in building a Go app that will recompress JPEG files in-place and in parallel. I have a prototype of that working, but don't worry, that's not in this request. I know I could use
jpeg-archiveor just do a child execution ofjpeg-recompress, but I wanted one deliverable binary.In addition to extracting the library, I did the following:
*.exeto.gitignore..editorconfigfile to ensure consistent use of spaces/tabs.Makefileto account to 64 bit builds of MozJPEG on LinuxreadFilesignature to take aconst char *to avoid unnecessary casting.Testing
I've tested on 64bit Linux and Windows 10.