Ensure any fields that could intersect with Message are renamed#321
Open
Gobot1234 wants to merge 8 commits intodanielgtaylor:masterfrom
Open
Ensure any fields that could intersect with Message are renamed#321Gobot1234 wants to merge 8 commits intodanielgtaylor:masterfrom
Gobot1234 wants to merge 8 commits intodanielgtaylor:masterfrom
Conversation
Collaborator
|
Which part of this is breaking? The change overall seems fine to me. |
cetanu
approved these changes
Jan 27, 2022
Collaborator
Author
|
I removed the which_one_of and serialised_on_wire methods |
Collaborator
|
I see... and they are attributes on the messages instead... That seems like good value in my opinion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows from a conversation with @danielgtaylor.
THIS IS A BREAKING CHANGE
parse -> parse_
serialized_on_wire -> serialized_on_wire_
foo -> foo
This allows us to reserve names for betterproto. I'll need to document this somewhere.