Improve (de-)serialization performance for scalar arrays#517
Closed
124C41p wants to merge 3 commits intodanielgtaylor:masterfrom
124C41p:scalar_array_speedup
Closed
Improve (de-)serialization performance for scalar arrays#517124C41p wants to merge 3 commits intodanielgtaylor:masterfrom 124C41p:scalar_array_speedup
124C41p wants to merge 3 commits intodanielgtaylor:masterfrom
124C41p:scalar_array_speedup
Conversation
This increases (de-)serialization speed of repeated scalar fields (of fixed length) drastically in the case they are used as numpy arrays.
Collaborator
|
Superseded by #545 |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #515
Since (de-)serialization is implemented purely in Python, it is quite slow compared to native implementations. I try to circumvent that issue by not deserializing repeated scalar fields immediately, but wrapping their byte representation inside the
ScalarArray[T]class instead. This class acts like a list. That is, you can calllen(a),a[i], andlist(a)for any ScalarArraya, and only at this point we actually deserialize (which is still very slow for big arrays).On the other hand, when using numpy you can also call
np.asarray(a)for any ScalarArrayato turn it into a numpy array in no time. Conversely, any numpy arraybcan be turned into aScalarArrayby callingScalarArray.from_numpy(b)to be passed to abetterprotodataclass field (instead of a list) for faster serialization speed.I tried to be as non-breaking as possible. That is, you can use lists everywhere you used them before. However, it was necessary to generate
Sequence[T]type hints whereList[T]hints were generated before. Also note that ScalarArray is an immutable data structure. So you might not be able to use.append()or.insert()on repeated fields as before (although it should be possible to makeScalarArraymutable if really needed).What do you think about this approach?