tests: add an encoding roundtrip for Struct#559
Draft
woodruffw wants to merge 2 commits intodanielgtaylor:masterfrom
Draft
tests: add an encoding roundtrip for Struct#559woodruffw wants to merge 2 commits intodanielgtaylor:masterfrom
woodruffw wants to merge 2 commits intodanielgtaylor:masterfrom
Conversation
7 tasks
Contributor
Author
|
Just to post a brief update: per #551 (comment) and below, I don't yet have a great idea for a patch here. The basic thing that needs to happen is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows #551. This currently fails, as expected, since
dump()is not correctly specialized forStruct.This is a work in progress.
Checklist