fix: Message.to_pydict and .from_pydict#609
Open
RF-Tar-Railt wants to merge 2 commits intodanielgtaylor:masterfrom
Open
fix: Message.to_pydict and .from_pydict#609RF-Tar-Railt wants to merge 2 commits intodanielgtaylor:masterfrom
RF-Tar-Railt wants to merge 2 commits intodanielgtaylor:masterfrom
Conversation
Collaborator
|
What is this fixing? Please can you also provide tests so that this doesn't happen in the future |
Author
updated |
|
Could a reviewer please take a look at this? It makes protobufs containing |
cetanu
approved these changes
Jan 5, 2025
|
@cetanu Thx for reviewing! When do branches get merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve #610
Just one line different:
to_dict:to_pydict:from_pydictis the same cause.Checklist