Merged
Conversation
Fix some issues flagged by poetry check.
abn
requested changes
Jan 13, 2025
abn
reviewed
Jan 13, 2025
Co-authored-by: Arun Babu Neelicattu <arun.neelicattu@gmail.com>
Co-authored-by: Arun Babu Neelicattu <arun.neelicattu@gmail.com>
Collaborator
|
The CI Is still installing Poetry 1.8.5. Might need to update that in a separate PR first. |
jameshilliard
force-pushed
the
fix-poetry
branch
6 times, most recently
from
ba6692d to
8b7d1c4
Compare
jameshilliard
force-pushed
the
fix-poetry
branch
from
8b7d1c4 to
ebe94e2
Compare
Contributor
Author
|
I think I got tests all passing now, had to drop python 3.8 support(python 3.8 is deprecated). |
abn
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some issues flagged by poetry check.