Skip to content

current progress#6

Draft
FujishigeTemma wants to merge 3 commits intodanielmk:masterfrom
FujishigeTemma:master
Draft

current progress#6
FujishigeTemma wants to merge 3 commits intodanielmk:masterfrom
FujishigeTemma:master

Conversation

@FujishigeTemma
Copy link
Copy Markdown

@FujishigeTemma FujishigeTemma commented May 26, 2023

  • use os.path.join
  • use devcontainer
  • add a better saving method for APs
  • any other changes are auto format

Comment thread ouropy/gennetwork.py Outdated

curr_shelve = shelve.open(full_file_path, flag='n')
# BUG with paradigm_frequency_inhibition at 1Hz, possibly too long sim?
curr_shelve['populations'] = [[(i, timestamps) for i, timestamps in enumerate(p.get_timestamps()) if len(timestamps) > 0] for p in self.populations]
Copy link
Copy Markdown
Author

@FujishigeTemma FujishigeTemma May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here(L210) is the only change I want you to check:pray:

@danielmk
Copy link
Copy Markdown
Owner

This generally works but it has the disadvantage that it produces a ragged list of lists (ragged meaning, that the lists have different sizes depending on the number of spikes. The issue with this is that when we convert this to an array the datatype of the array is object rather than a numerical type, which makes it annoying to deal with.

The way I am doing it now is that I have one array that contains the unit that emitted the spike and another array with the spike time.

So I would suggest something along those lines: curr_shelve['populations'] = [[(i, ts) for i, timestamps in enumerate(p.get_timestamps()) for ts in timestamps] for p in self.populations]

But I would have to actually run the code in the lab to know if the details are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants