Skip to content

Comments

Replace feature = "cargo-clippy"#41

Merged
danielparks merged 1 commit intomainfrom
cfg-clippy
Jun 18, 2024
Merged

Replace feature = "cargo-clippy"#41
danielparks merged 1 commit intomainfrom
cfg-clippy

Conversation

@danielparks
Copy link
Owner

cfg(feature = "cargo-clippy") has been deprecated. The correct way to achieve the same result is now cfg(clippy).


Waiting on this work on stable Rust. Currently:

  • ❌ Running cargo clippy on code that uses feature = "cargo-clippy" does not complain.
  • ❌ Running cargo +nightly clippy on code that uses feature = "cargo-clippy" does not complain.
  • not(cfg(clippy)) does not work on stable clippy — clippy ignores the cfg and lints the code.
  • not(cfg(clippy)) does work on nightly clippy — clippy ignores the code.

I’m unsure when any part of this will be stabilized. (Comment on the blog post PR.)

`cfg(feature = "cargo-clippy")` has been [deprecated]. The correct way
to achieve the same result is now `cfg(clippy)`.

[deprecated]: rust-lang/rust-clippy#12292
@danielparks danielparks marked this pull request as ready for review June 18, 2024 06:55
@danielparks
Copy link
Owner Author

Apparently this was stabilized in Rust 1.78.0.

@danielparks danielparks merged commit 806789c into main Jun 18, 2024
@danielparks danielparks deleted the cfg-clippy branch June 18, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant