Skip to content

Update dependency sequelize to v6 [SECURITY]#68

Open
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/npm-sequelize-vulnerability
Open

Update dependency sequelize to v6 [SECURITY]#68
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/npm-sequelize-vulnerability

Conversation

@renovate
Copy link
Copy Markdown

@renovate renovate bot commented Mar 16, 2023

ℹ️ Note

This PR body was truncated due to platform limits.

This PR contains the following updates:

Package Change Age Confidence
sequelize (source) ^4.17.2^6.29.0 age confidence

GitHub Vulnerability Alerts

CVE-2023-25813

Impact

The SQL injection exploit is related to replacements. Here is such an example:

In the following query, some parameters are passed through replacements, and some are passed directly through the where option.

User.findAll({
  where: or(
    literal('soundex("firstName") = soundex(:firstName)'),
    { lastName: lastName },
  ),
  replacements: { firstName },
})

This is a very legitimate use case, but this query was vulnerable to SQL injection due to how Sequelize processed the query: Sequelize built a first query using the where option, then passed it over to sequelize.query which parsed the resulting SQL to inject all :replacements.

If the user passed values such as

{
  "firstName": "OR true; DROP TABLE users;",
  "lastName": ":firstName"
}

Sequelize would first generate this query:

SELECT * FROM users WHERE soundex("firstName") = soundex(:firstName) OR "lastName" = ':firstName'

Then would inject replacements in it, which resulted in this:

SELECT * FROM users WHERE soundex("firstName") = soundex('OR true; DROP TABLE users;') OR "lastName" = ''OR true; DROP TABLE users;''

As you can see this resulted in arbitrary user-provided SQL being executed.

Patches

The issue was fixed in Sequelize 6.19.1

Workarounds

Do not use the replacements and the where option in the same query if you are not using Sequelize >= 6.19.1

References

See this thread for more information: https://github.com/sequelize/sequelize/issues/14519

Snyk: https://security.snyk.io/vuln/SNYK-JS-SEQUELIZE-2932027

Severity
  • CVSS Score: 10.0 / 10 (Critical)
  • Vector String: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:C/C:H/I:H/A:H

CVE-2023-22580

Due to improper input filtering in the sequelize js library, can malicious queries lead to sensitive information disclosure.

Severity
  • CVSS Score: 5.3 / 10 (Medium)
  • Vector String: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:N

CVE-2023-22579

Impact

Providing an invalid value to the where option of a query caused Sequelize to ignore that option instead of throwing an error.

A finder call like the following did not throw an error:

User.findAll({
  where: new Date(),
});

As this option is typically used with plain javascript objects, be aware that this only happens at the top level of this option.

Patches

This issue has been patched in sequelize@6.28.1 & @sequelize/core@7.0.0.alpha-20

References

A discussion thread about this issue is open at https://github.com/sequelize/sequelize/discussions/15698

CVE: CVE-2023-22579
Snyk: https://security.snyk.io/vuln/SNYK-JS-SEQUELIZE-3324090

Severity
  • CVSS Score: 10.0 / 10 (Critical)
  • Vector String: CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:C/C:H/I:H/A:H

CVE-2023-22578

Impact

Sequelize 6.28.2 and prior has a dangerous feature where using parentheses in the attribute option would make Sequelize use the string as-is in the SQL

User.findAll({
  attributes: [
    ['count(id)', 'count']
  ]
});

Produced

SELECT count(id) AS "count" FROM "users"

Patches

This feature was deprecated in Sequelize 5, and using it prints a deprecation warning.

This issue has been patched in @sequelize/core@7.0.0.alpha-20 and sequelize@6.29.0.

In Sequelize 7, it now produces the following:

SELECT "count(id)" AS "count" FROM "users"

In Sequelize 6, it throws an error explaining that we had to introduce a breaking change, and requires the user to explicitly opt-in to either the Sequelize 7 behavior (always escape) or the Sequelize 5 behavior (inline attributes that include () without escaping). See https://github.com/sequelize/sequelize/pull/15710 for more information.

Mitigations

Do not use user-provided content to build your list or attributes. If you do, make sure that attribute in question actually exists on your model by checking that it exists in the rawAttributes property of your model first.


A discussion thread about this issue is open at https://github.com/sequelize/sequelize/discussions/15694
CVE: CVE-2023-22578

Severity
  • CVSS Score: 10.0 / 10 (Critical)
  • Vector String: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:C/C:H/I:H/A:H

Release Notes

sequelize/sequelize (sequelize)

v6.29.0

Compare Source

v6.28.2

Compare Source

v6.28.1

Compare Source

v6.28.0

Compare Source

v6.27.0

Compare Source

v6.26.0

Compare Source

v6.25.8

Compare Source

v6.25.7

Compare Source

v6.25.6

Compare Source

v6.25.5

Compare Source

v6.25.4

Compare Source

v6.25.3

Compare Source

v6.25.2

Compare Source

v6.25.1

Compare Source

v6.25.0

Compare Source

v6.24.0

Compare Source

v6.23.2

Compare Source

v6.23.1

Compare Source

v6.23.0

Compare Source

v6.22.1

Compare Source

v6.22.0

Compare Source

v6.21.6

Compare Source

v6.21.5

Compare Source

v6.21.4

Compare Source

v6.21.3

Compare Source

v6.21.2

Compare Source

v6.21.1

Compare Source

v6.21.0

Compare Source

v6.20.1

Compare Source

v6.20.0

Compare Source

v6.19.2

Compare Source

v6.19.1

Compare Source

v6.19.0

Compare Source

v6.18.0

Compare Source

v6.17.0

Compare Source

v6.16.3

Compare Source

v6.16.2

Compare Source

v6.16.1

Compare Source

Bug Fixes

v6.16.0

Compare Source

Features

v6.15.1

Compare Source

Bug Fixes

v6.15.0

Compare Source

Bug Fixes
Features

v6.14.1

Compare Source

Bug Fixes

v6.14.0

Compare Source

Bug Fixes
Features

v6.13.0

Compare Source

Bug Fixes
Features

v6.12.5

Compare Source

Bug Fixes

v6.12.4

Compare Source

Bug Fixes
  • mssql/async-queue: fix unable to start mysql due to circular ref (#​13823) (49e8614)

v6.12.3

Compare Source

Bug Fixes

v6.12.2

Compare Source

Bug Fixes

v6.12.1

Compare Source

Bug Fixes

v6.12.0

Compare Source

Bug Fixes
Features

v6.11.0

Compare Source

Features

v6.10.0

Compare Source

Bug Fixes
Features
  • definitions: Adds AbstractQuery and before/afterQuery hook definitions (#​13635) (37a5858)
  • postgresql: easier SSL config and options param support (#​13673) (9591573)

v6.9.0

Compare Source

Bug Fixes
Features

v6.8.0

Compare Source

Bug Fixes
Features

v6.7.0

Compare Source

Bug Fixes
Features

v6.6.5

Compare Source

Bug Fixes

v6.6.4

Compare Source

Bug Fixes

v6.6.2

Compare Source

Bug Fixes

v6.6.1

Compare Source

Bug Fixes

v6.6.0

Compare Source

Bug Fixes
Features

v6.5.1

Compare Source

Bug Fixes
  • mysql: release connection on deadlocks (#​13102) (6388507)
    • Note: this complements the work done in 6.5.0, fixing another situation not covered by it with MySQL.
  • types: allow transaction to be null (#​13093) (ced4dc7)

v6.5.0

Compare Source

Second release in 2021! 🎉

Bug Fixes
Features

v6.4.0

Compare Source

First release in 2021! 🎉

Bug Fixes
Features

v6.3.5

Compare Source

Bug Fixes
  • truncate: fix missing await in truncate all models with cascade (#​12664) (933b3f6)

v6.3.4

Compare Source

Bug Fixes

v6.3.3

Compare Source

Bug Fixes

v6.3.2

Compare Source

Bug Fixes

v6.3.1

Compare Source

Bug Fixes

v6.3.0

Compare Source

Bug Fixes
Features

v6.2.4

Compare Source

Bug Fixes

v6.2.3

Compare Source

Bug Fixes
  • sqlite: describeTable now returns unique constraint and references (#​12420) (2de3377)

v6.2.2

Compare Source

Bug Fixes
  • types: fixed types for model.init and sequelize.define; update docs (#​12435) (9c446f9)

v6.2.1

Compare Source

Bug Fixes
  • mssql: insert/upsert operations do not return all fields (#​12433) (aeb318a)

v6.2.0

Compare Source

Bug Fixes
Features
  • types: added optional stricter typing for Model attributes (#​12405) (871157b)

v6.1.1

Compare Source

Bug Fixes

v6.1.0: v6

Compare Source

Sequelize v6 is the next major release after v5. Below is a list of breaking changes to help you upgrade.

Breaking Changes

Support for Node 10 and up

Sequelize v6 will only support Node 10 and up #​10821.

CLS

You should now use cls-hooked package for CLS support.

  const cls = require('cls-hooked');
  const namespace = cls.createNamespace('....');
  const Sequelize = require('sequelize');

  Sequelize.useCLS(namespace);
Database Engine Support

We have updated our minimum supported database engine versions. Using older database engine will show SEQUELIZE0006 deprecation warning. Please check ENGINE.md for version table.

Sequelize
  • Bluebird has been removed. Internally all methods are now using async/await. Public API now returns native promises. Thanks to Andy Edwards for this refactor work.
  • Sequelize.Promise is no longer available.
  • sequelize.import method has been removed.
Model
options.returning

Option returning: true will no longer return attributes that are not defined in the model. Old behavior can be achieved by using returning: ['*'] instead.

Model.changed()

This method now tests for equality with _.isEqual and is now deep aware for JSON objects. Modifying a nested value for a JSON object won't mark it as changed (since it is still the same object).

  const instance = await MyModel.findOne();

  instance.myJsonField.someProperty = 12345; // Changed from something else to 12345
  console.log(instance.changed()); // false

  await instance.save(); // this will not save anything

  instance.changed('myJsonField', true);
  console.log(instance.changed()); // ['myJsonField']

  await instance.save(); // will save
Model.bulkCreate()

This method now throws Sequelize.AggregateError instead of Bluebird.AggregateError. All errors are now exposed as errors key.

Model.upsert()

Native upsert is now supported for all dialects.

const [instance, created] = await MyModel.upsert({});

Signature for this method has been changed to Promise<Model,boolean | null>. First index contains upserted instance, second index contains a boolean (or null) indicating if record was created or updated. For SQLite/Postgres, created value will always be null.

  • MySQL - Implemented with ON DUPLICATE KEY UPDATE
  • PostgreSQL - Implemented with ON CONFLICT DO UPDATE
  • SQLite - Implemented with ON CONFLICT DO UPDATE
  • MSSQL - Implemented with MERGE statement

Note for Postgres users: If upsert payload contains PK field, then PK will be used as the conflict target. Otherwise first unique constraint will be selected as the conflict key.

QueryInterface
addConstraint

This method now only takes 2 parameters, tableName and options. Previously the second parameter could be a list of column names to apply the constraint to, this list must now be passed as options.fields property.

Changelog

6.0.0-beta.7
  • docs(associations): belongs to many create with through table
  • docs(query-interface): fix broken links #​12272
  • docs(sequelize): omitNull only works for CREATE/UPDATE queries
  • docs: asyncify #​12297
  • docs: responsive #​12308
  • docs: update feature request template
  • feat(postgres): native upsert #​12301
  • feat(sequelize): allow passing dialectOptions.options from url #​12404
  • fix(include): check if attributes specified for included through model #​12316
  • fix(model.destroy): return 0 with truncate #​12281
  • fix(mssql): empty order array generates invalid FETCH statement #​12261
  • fix(postgres): parse enums correctly when describing a table #​12409
  • fix(query): ensure correct return signature for QueryTypes.RAW #​12305
  • fix(query): preserve cls context for logger #​12328
  • fix(query-generator): do not generate GROUP BY clause if options.group is empty #​12343
  • fix(reload): include default scope #​12399
  • fix(types): add Association into OrderItem type #​12332
  • fix(types): add clientMinMessages to Options interface #​12375
  • fix(types): transactionType in Options #​12377
  • fix(types): add support for optional values in "where" clauses #​12337
  • fix(types): add missing fields to 'FindOrCreateType' #​12338
  • fix: add missing sql and parameters properties to some query errors #​12299
  • fix: remove custom inspect #​12262
  • refactor: cleanup query generators [#​12304](h

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • ""
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch from 9e13b25 to 968253d Compare March 25, 2023 03:07
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 2 times, most recently from 7034d40 to fb80aa3 Compare April 3, 2023 11:37
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 2 times, most recently from dc0cfde to f718004 Compare April 17, 2023 16:17
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 3 times, most recently from 5d6aea5 to 1fe5267 Compare June 4, 2023 08:16
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch from 1fe5267 to c90c9f4 Compare June 4, 2023 15:26
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 6 times, most recently from d7c4026 to 054825f Compare June 19, 2023 11:34
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 2 times, most recently from 1dabf76 to 632a5eb Compare June 29, 2023 13:40
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 4 times, most recently from d501fbd to 1213393 Compare July 9, 2023 12:21
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 4 times, most recently from 90d1c15 to bc0a5e3 Compare July 19, 2023 17:33
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 4 times, most recently from 0b0585d to 67d6549 Compare August 1, 2023 18:13
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch from 67d6549 to 7493f82 Compare August 9, 2023 14:56
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 4 times, most recently from f0612a7 to e4a3fa7 Compare October 15, 2023 17:25
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 2 times, most recently from e8f865a to e22bce2 Compare October 23, 2023 16:19
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 2 times, most recently from 0885ed4 to bc01009 Compare November 6, 2023 11:07
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 2 times, most recently from 871b216 to 8afcbeb Compare November 16, 2023 14:15
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 2 times, most recently from 82606b9 to d74cb36 Compare December 3, 2023 14:20
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 2 times, most recently from d3a748b to 5dac922 Compare December 12, 2023 12:14
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 4 times, most recently from 6df2c06 to 3459e65 Compare January 4, 2024 17:17
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 2 times, most recently from 547a1b6 to 1e8b7de Compare January 9, 2024 16:09
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 2 times, most recently from cefcd3a to 4b966b0 Compare January 16, 2024 16:15
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 2 times, most recently from 43bb74d to 54a4ef0 Compare January 28, 2024 15:58
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 2 times, most recently from aae2959 to 5d49254 Compare February 4, 2024 12:12
@renovate renovate bot force-pushed the renovate/npm-sequelize-vulnerability branch 3 times, most recently from ee3c14b to d72cd1b Compare February 29, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants