Fix for Issue #33 - Building with idf.py fails#35
Fix for Issue #33 - Building with idf.py fails#35project-x51 wants to merge 2 commits intodanjulio:masterfrom
Conversation
- Also added error handling on call to i2c_param_config
|
Hey Robin, I'm definitely interested in moving to 4.4.1 and it seems you did all the hard work. So thank you for that. As you might have noticed I just released a big change (version 3.0) so I'll have to take a look how best to integrate. I hope to get to that later this week. Cheers, Dan |
|
Hi Dan, The changes were made to the version 3.0 code base so it should be just a matter of merging them with the master branch. There are a number of warnings for depreciated calls that would ideally be resolved to make the code 100% V4.41. Robin |
|
Hey Robin, I installed IDF 4.4.2 (current "stable") and merged your changes in a local repository, compiled and successfully loaded a camera! I see the deprecated calls and agree, they need to be fixed (there are also some warnings about assignments in different structure types now). I also see that the new IDF allocates different amounts of memory which makes me a little nervous (obviously they changed stuff under the hood). So my plan is to fix the deprecated calls, do a lot of testing, include other bug fixes and changes and then commit this new version back as 3.1 with 4.4.2 as the new build environment. FYI: I had made some changes to the Flash configuration in the sdkconfig (80 MHz QIO accesses) which I don't think you got in the new sdkconfig. Let me know if you'd like to see my sdkconfig. Again, thank you for the effort and for sharing your changes. Regards, Dan |
Hi Danjulio,
I hope this helps.
Robin