Skip to content

Restore correct revision subheader for 3.22#186

Merged
dankogai merged 1 commit into
dankogai:mainfrom
jkeenan:correct-duplicate-revision-subheader-20260427
Apr 27, 2026
Merged

Restore correct revision subheader for 3.22#186
dankogai merged 1 commit into
dankogai:mainfrom
jkeenan:correct-duplicate-revision-subheader-20260427

Conversation

@jkeenan
Copy link
Copy Markdown
Contributor

@jkeenan jkeenan commented Apr 27, 2026

While attempting to synch Encode-3.23 into the Perl 5 core distribution, I noticed two subsection headers for Revision 3.23 in Changes.

  $ git diff 3.22..3.23 -- Changes
  diff --git a/Changes b/Changes
  index d460234..ed6a785 100644
  --- a/Changes
  +++ b/Changes
  @@ -1,8 +1,13 @@
   # Revision history for Perl extension Encode.
   #
  -# $Id: Changes,v 3.22 2026/04/25 16:36:51 dankogai Exp $
  +# $Id: Changes,v 3.23 2026/04/27 03:01:25 dankogai Exp dankogai $
   #
  -$Revision: 3.22 $ $Date: 2026/04/25 16:36:51 $
  +$Revision: 3.23 $ $Date: 2026/04/27 03:01:25 $
  +! t/Unicode_trailing_nul.t
  +  readdress RT#152013: Unicode_trailing_nul.t leaves a temp file
  +  https://github.com/dankogai/p5-encode/commit/f01eac7df7185a836ca5825d7bf2bd9510a3826b + +$Revision: 3.23 $ $Date: 2026/04/27 03:01:25 $ ! lib/Encode/Supported.pod Pulled: Encode::Supported: fix broken link https://github.com/dankogai/p5-encode/pull/182

While attempting to synch Encode-3.23 into the Perl 5 core distribution,
I noticed two subsection headers for Revision 3.23 in Changes.

  $ git diff 3.22..3.23 -- Changes
  diff --git a/Changes b/Changes
  index d460234..ed6a785 100644
  --- a/Changes
  +++ b/Changes
  @@ -1,8 +1,13 @@
   # Revision history for Perl extension Encode.
   #
  -# $Id: Changes,v 3.22 2026/04/25 16:36:51 dankogai Exp $
  +# $Id: Changes,v 3.23 2026/04/27 03:01:25 dankogai Exp dankogai $
   #
  -$Revision: 3.22 $ $Date: 2026/04/25 16:36:51 $
  +$Revision: 3.23 $ $Date: 2026/04/27 03:01:25 $
  +! t/Unicode_trailing_nul.t
  +  readdress RT#152013: Unicode_trailing_nul.t leaves a temp file
  +  dankogai@f01eac7
  +
  +$Revision: 3.23 $ $Date: 2026/04/27 03:01:25 $
   ! lib/Encode/Supported.pod
     Pulled: Encode::Supported: fix broken link
     dankogai#182
@dankogai dankogai merged commit 2ad761f into dankogai:main Apr 27, 2026
6 checks passed
@jkeenan jkeenan deleted the correct-duplicate-revision-subheader-20260427 branch April 27, 2026 12:20
@dankogai
Copy link
Copy Markdown
Owner

Thank you! I've noticed that too but I decided to pull this pr first before further fixes.
eac1089
05e6d55

ap pushed a commit to Perl/perl5 that referenced this pull request May 4, 2026
$Revision: 3.24 $ $Date: 2026/04/29 17:36:34 $
! Byte/Makefile.PL
  Pulled: Byte/Makefile.PL: ensure build reproducibility again
  dankogai/p5-encode#187
! Changes
  More fixes to revision subheaders
  dankogai/p5-encode@eac1089
  Pulled: Restore correct revision subheader for 3.22
  dankogai/p5-encode#186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants