bugfix - preserve decorated callable defaults across aliases (#703)#704
Merged
dannymeijer merged 1 commit intoMay 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes callable default-argument preservation for decorated functions and methods when the decorated callable surface still matches the source declaration, including direct imports, public facade re-exports, alias re-exports, and alias-expanded
Union[...]parameter surfaces. It also moves call-site signature selection toward one canonical merge path so source defaults and imported callable metadata do not diverge across module boundaries.Type of change
docs/RFCs/*)Area(s)
Select the primary areas touched (used for review routing; labels are managed separately):
Key details
count()no longer lose defaults because the defining signature crossed a module boundary.Testing / verification
make test/cargo testmake examples(if relevant)incan fmt --check .(if relevant)Manual verification notes:
cargo test --test cli_integration test_decorated_functions_preserve_default_argument_calls_issue703 --features lspcargo test --test cli_integration test_imported_partial_preset_defaults_survive_decorator_argument_issue698 --features lspcargo test --test cli_integration test_decorator_callable_exposes_source_name_issue694 --features lspcargo test --test cli_integration issue70 --features lspcargo test --test cli_integration issue69 --features lspcargo test --test codegen_snapshot_tests user_defined_decoratorscargo test --test integration_tests e2e_imported_generic_decorator_factory_preserves_function_signaturescargo test --test integration_tests e2e_method_call_decorator_factories_use_checked_receiver_loweringgit diff --checkmake pre-commitDocs impact
If docs updated:
workspaces/docs-site/docs/release_notes/0_3.mdChecklist
Closes #703