feat: detect and repair inline stop-hook progress resume issue#234
feat: detect and repair inline stop-hook progress resume issue#234danshapiro wants to merge 7 commits intomainfrom
Conversation
… plan 1. repair() builds ParsedMessage inline without the new fields (subtype, toolUseID, dataType, dataHookEvent), so detectInlineStopHookProgress would always return undefined inside repair(). Added explicit step to update the inline construction. 2. Service waitForSession() calls queue.enqueue() then queue.waitFor(), but waitFor() checks this.processed first and returns the stale resume-issue result immediately. Added clearProcessed() method to queue and clearProcessed calls before each enqueue+waitFor sequence. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 778290f39b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (existing.resumeIssue) { | ||
| this.queue.clearProcessed(sessionId) | ||
| this.queue.enqueue([{ sessionId, filePath: existing.filePath, priority: 'active' }]) | ||
| return this.queue.waitFor(sessionId, timeoutMs) |
There was a problem hiding this comment.
This requeue path only handles sessions that already have a processed/cached result, but waitForSession still returns early for sessions that are merely queued (this.queue.has(sessionId)) without promoting their priority. That means a session discovered at startup with priority: 'disk' can be awaited as-is, scanned without resume-issue repair, and returned as healthy with resumeIssue still present, so terminal.create can continue with a broken --resume despite this method being the active-resume guard.
Useful? React with 👍 / 👎.
1 participant
Summary
assistant -> progress(hook_progress/Stop) -> stop_hook_summary -> turn_duration?) asresumeIssue: 'inline_stop_hook_progress'while keeping the sessionstatus: 'healthy'stop_hook_summary.parentUuidto bypass the progress record, leaving it as a preserved side leafterminal.createTest plan
npm run typecheck: zero errorsturnCompletionSlice.test.tsandterminal-registry.test.tsMCP injection tests (also fail on main)🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com