Match sidebar title search on subdirectories#240
Match sidebar title search on subdirectories#240danshapiro wants to merge 23 commits intofix/mcp-param-validationfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c4fb06e34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!sidebarHasMore || sidebarWindow?.loading || loadMoreInFlightRef.current) return | ||
| if (sidebarOldestLoadedTimestamp == null || sidebarOldestLoadedSessionId == null) return | ||
| if (hasActiveQuery) return | ||
| if (hasAppliedQuery) return |
There was a problem hiding this comment.
This guard only checks appliedQuery, so after a search from browse fails before any replacement commit, the window can be in query='foo' and appliedQuery=''. In that state, infinite-scroll pagination is allowed and calls fetchSessionWindow({ append: true }), which defaults to an empty query and updates requested state back to browse, unexpectedly clearing the user’s search text/results. This is user-visible whenever a non-empty requested search errors or aborts before commit; the append path should also be blocked when sidebarWindow.query is non-empty.
Useful? React with 👍 / 👎.
1 participant
Summary
Test Plan
FRESHELL_TEST_SUMMARY='pre-merge full suite after rebasing onto local main' npm testnpm run test:statusFRESHELL_TEST_SUMMARY='sidebar stale-commit debounce regression' npm run test:vitest -- test/unit/client/components/Sidebar.test.tsxFRESHELL_TEST_SUMMARY='review follow-up full check' npm run check