-
Notifications
You must be signed in to change notification settings - Fork 16
feat: clickable terminal URLs with context menu #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
778d5ef
plan: clickable terminal URLs with context menu integration
8f744dc
plan: improve clickable-terminal-urls plan with verified code references
3abd4ed
plan: refine clickable-terminal-urls plan after code verification
380e949
plan: fix xterm link provider priority order and test file references
1fd41c8
test-plan: concrete enumerated test plan for clickable terminal URLs
1ab57eb
feat: add terminal-hovered-url and url-utils utility modules with tests
b985ad6
feat: URL click opens browser pane, add hover/leave tracking and URL …
104e755
feat: add URL context menu items for terminal panes
5b3c8b2
test: add integration tests for URL click and context menu
5e07f7b
test: add hidden state cleanup test for hovered URL
78c1829
fix: update file link test to capture first provider, not last
5a563cc
refactor: fix lint issues in url-utils and TerminalView cleanup
0d78a20
fix: balanced parens in URL detection, scheme validation on OSC 8 lin…
51c4b62
fix: add button guard to prevent right/middle-click link activation
960aed7
fix: defer terminal pane splits after xterm pointer events
181f599
fix: type queued terminal pane splits as pane inputs
6d3cc63
Merge remote-tracking branch 'upstream/main' into clickable-terminal-…
mattleaverton 83b01cb
fix: block non-http schemes in OSC 8 link handler
mattleaverton b935ea3
Merge remote-tracking branch 'upstream/main' into clickable-terminal-…
mattleaverton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // Tracks which URL is currently hovered per terminal pane for context menus. | ||
|
|
||
| const hoveredUrls = new Map<string, string>() | ||
|
|
||
| export function setHoveredUrl(paneId: string, url: string): void { | ||
| hoveredUrls.set(paneId, url) | ||
| } | ||
|
|
||
| export function clearHoveredUrl(paneId: string): void { | ||
| hoveredUrls.delete(paneId) | ||
| } | ||
|
|
||
| export function getHoveredUrl(paneId: string): string | undefined { | ||
| return hoveredUrls.get(paneId) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The terminal context menu forwards
target.hoveredUrldirectly into pane navigation without scheme validation. For OSC8 links,hoveredUrlis populated fromlinkHandler.hoveras raw link text, so ajavascript:/data:OSC8 URI can still be opened via “Open URL in pane/new tab,” bypassing the scheme check added to left-click activation and reintroducing unsafe URI handling through the right-click path.Useful? React with 👍 / 👎.