[codex] add required client typecheck workflow#246
Draft
danshapiro wants to merge 1 commit intomainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run typecheck:clienton every pull request and pushes tomainnpm run typecheck:clientas the cheap client-side compile gate in the testing skill docsWhy
A recent regression made it through
npm testbecause the behavior tests were green while TypeScript still rejected the code. The missing safety net was the cheap client-only compile gate:npm run typecheck:clientcatches those issues in about eight seconds, versus roughly ninety-five seconds fornpm run check.Impact
npm testandnpm run checkworkflows remain available for broader verificationValidation
.github/workflows/typecheck-client.ymlwith PyYAMLgit diff --check