feat(cli): add --validate alias for --preflight in attractor run#59
Open
mvanhorn wants to merge 3 commits intodanshapiro:mainfrom
Open
feat(cli): add --validate alias for --preflight in attractor run#59mvanhorn wants to merge 3 commits intodanshapiro:mainfrom
mvanhorn wants to merge 3 commits intodanshapiro:mainfrom
Conversation
Adds --validate as a synonym for --preflight/--test-run in the attractor run command, matching the flag name proposed in danshapiro#47. Updates usage text, error messages, and adds test coverage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…i/ paths - Add gpt-5.3-codex-spark to cliOnlyModelIDs map (fixes TestIsCLIOnlyModel) - Replace root .ai/verify_errors.log and .ai/test-evidence/latest/ with run-scoped .ai/runs/$KILROY_RUN_ID/ paths in demo spec (fixes TestReferenceSurfaces_NoLegacyRootAIScratchPaths) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47
Adds
--validateas a synonym for--preflight/--test-runin theattractor runcommand. This gives operators the intuitive flag name proposed in the issue while preserving backward compatibility with the existing flags.Changes
--validatecase to the flag parser inattractorRun()(aliases to samepreflightOnlybool)--validate|--preflight|--test-runTestAttractorRun_ValidateAlias_AcceptedtestTestAttractorRun_PreflightRejectsDetachandTestUsage_IncludesPreflightFlagsfor the new flagTest plan
go build ./cmd/kilroy/compiles cleanlyTestAttractorRun_ValidateAlias_Accepted- verifies--validatetriggers preflight-only modeTestAttractorRun_PreflightRejectsDetach- verifies--validate/--preflight/--test-runreject--detachTestUsage_IncludesPreflightFlags- verifies usage text includes--validateThis contribution was developed with AI assistance (Claude Code).