fix(test): update cli_only_models_test for gpt-5.4 model rename#67
Open
leegonzales wants to merge 1 commit intodanshapiro:mainfrom
Open
fix(test): update cli_only_models_test for gpt-5.4 model rename#67leegonzales wants to merge 1 commit intodanshapiro:mainfrom
leegonzales wants to merge 1 commit intodanshapiro:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli_only_models_test.gofrom oldGPT-5.3-CODEX-SPARKtoGPT-5.4-SPARKto match model refactoring (a13d131, 297285b, f08ceb5)gofmtformatting to this file (last unformatted file in repo)Context
The recent model centralization commits upgraded from gpt-5.3-codex to gpt-5.4 but left one test case referencing the old model name. This also subsumes PR #65 (gofmt-only fix for the same file).
Validation
go test ./internal/attractor/engine/ -run TestIsCLIOnlyModel— PASSgofmt -l .— clean (no unformatted files)go vet ./...— cleango build ./cmd/kilroy/— cleanPre-existing failures (not caused by this change)
TestRunWithConfig_APIBackend_SessionEventsPreventFalseStallWithoutHeartbeat(codergen_heartbeat_test.go:319)TestReferenceSurfaces_NoLegacyRootAIScratchPaths(demo/substack-spec-v01.dot has legacy .ai/ paths)🤖 Generated by Servitor heartbeat