Draft
Conversation
Owner
|
Does not compile according to git actions |
Collaborator
Author
It's a super rough Draft, sorry for not making it more clear. I opened it only to share the extended version of Debug::log. |
…ak .yml file to install openssl in the ubuntu container running the tests
Collaborator
Author
Now it's solved. |
Collaborator
Author
|
I mean. It compiles. Https is not implemented yet. The problem was that openssl needs to be installed as dependencies into the container of Github Actions. |
…nd add logic to acceptNewConnection to create a ssl struct for the connection and pass it to the Connection object on initialisation
Collaborator
Author
|
Another couple of hours for another small step forward. More tomorrow. Not so far from the end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll open this only for visibility. It has a batter version of the Debug::log function that takes also color as (optional) option. @dantol29
Sure! Here's a comprehensive list of what we have done so far and what remains to be done for implementing HTTPS support in your HTTP server, presented in a checklist format.
SSL Integration Checklist
SSLManager and SSLContext: Implemented singleton
SSLManagerandSSLContextclasses for managing SSL/TLS initialization and context.SSLManager.SSLContext.Accepting SSL Connections: Modified the
acceptNewConnectionmethod to handle SSL connections.Connectionobject.Read Data from SSL Connections: Implement SSL-enabled reading in the
readSocketmethod of theConnectionclass.SSL_readinstead ofrecv.Write Data to SSL Connections: Implement SSL-enabled writing in the
writeSocketmethod of theConnectionclass.SSL_writeinstead ofsend.Cleanup SSL Resources: Ensure proper cleanup of SSL resources when a connection is closed.
SSL_shutdownandSSL_freeare called in thecloseClientConnectionmethod.Configuration: Ensure the server is correctly configured to differentiate between HTTP and HTTPS connections.
SSL_PORTand ensure it's used consistently.