Adjustment in initial suggestions logic#77
Adjustment in initial suggestions logic#77castanonrodrigo wants to merge 1 commit intodanvick:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
- Coverage 35.12% 34.71% -0.42%
==========================================
Files 3 3
Lines 242 242
==========================================
- Hits 85 84 -1
- Misses 157 158 +1
Continue to review full report at Codecov.
|
| void _handleFocusChanged() { | ||
| if (_focusNode.hasFocus) { | ||
| _openInputConnection(); | ||
| _suggestions = widget.initialSuggestions |
There was a problem hiding this comment.
My gut suggests that _suggestions should not repeatedly initialize from widget.initialSuggestions every time there is a focus change.
I'll need to analyze this more closely.
There was a problem hiding this comment.
I made it this way now because the value of _suggestions was being erased after the widget lost focus and therefore the suggestionsBox only appeared without the need of keyboard input on the first time the field was focused.
But I appreciate you taking your time to look into it! If you think of another solution, please let me know.
3 participants
Minor adjustment in the previous PR I made adding the initalSuggestions parameter.
Now, if initialSuggestions is set, the suggestions box will appear every time the input gains focus