Dapr state store clickhouse#3675
Conversation
|
Thanks @middt, implementation generally looks good to me! Would it be possible to add conformance tests for this too? It seems like we should be able to spin up a click house docker compose. |
1b2a8de to
2c8934c
Compare
|
Thank you for the feedback! @JoshVanL I've implemented the conformance tests for the ClickHouse state store in this PR:
The tests verify all the key functionality including:
I've also addressed authentication issues by properly configuring username and password in both the Docker Compose setup and the state store implementation. All unit tests are now passing, confirming that the implementation works correctly with the ClickHouse server. |
|
Thanks @middt, I think the only thing left is to do a Appreciate the work on this! |
|
Done :) ! Just ran |
|
@middt - mind resolving the conflicts with |
46a191c to
fb148f1
Compare
|
Hi @cicoyle, I've resolved the conflicts in go.mod and go.sum by accepting the changes from the main branch, which includes the latest dependency updates. The changes have been pushed to the branch. The main updates include:
All tests are passing and the implementation remains unchanged. The PR should now be ready for review. |
|
@middt thanks for the PR 🎉 mind opening a dapr/docs PR targeting the 1.16 branch documenting this PR's details? |
|
Also, mind checking the linter locally? It appears to fail in CI |
5e268b9 to
9392000
Compare
Thanks for the feedback! @cicoyle I've already fixed all linter issues locally (import formatting, gosec warnings, variable shadowing, etc.) and the latest commits should pass CI. |
Absolutely! I've created a corresponding PR targeting the v1.16 branch with the same ClickHouse state store documentation. |
a305a6a to
a0e0d9a
Compare
|
@middt can you please run |
✅ Done! :) |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
ping pong |
Description
This PR adds a new state store component for ClickHouse, a column-oriented database management system. The ClickHouse state store component provides the following features:
Key implementation details:
Implementation Details
The component includes:
State store implementation (
clickhouse.go)Tests (
clickhouse_test.go)Configuration options:
Checklist
Testing Done
Tests were run against ClickHouse v23.8 using the official Go driver.
Additional Notes