Add Akeyless Secrets Store Component#4036
Conversation
a56fc84 to
b2a72bf
Compare
sicoyle
left a comment
There was a problem hiding this comment.
Thank you for iterating with me on this! Here's another batch of feedback for ya - I still have a bit more to review on this, but this is the main I think so far :) 🙌
tuvia-akeyless
left a comment
There was a problem hiding this comment.
LGTM. Please verify (manually/tests) it is working for various types of dynamic and rotated secrets.
This comment was marked as outdated.
This comment was marked as outdated.
bc57bc0 to
2718c8f
Compare
|
@sicoyle - can you please review this again? There were a bunch of merge conflicts and it happens every I update the branch. |
850536c to
4226c9f
Compare
Hi! Yes, thank you for your patience 🙏 I've been OOO for the past two weeks on vacation. I'm back now :) |
|
can you please rebase onto main? There are over 10k lines changed now in this PR with a ton of unrelated changes... |
e7bc2f8 to
bb84293
Compare
@sicoyle should be all cleaned up now. FYI, since your last review I added a few things:
|
sicoyle
left a comment
There was a problem hiding this comment.
few comments so far with the additions. I will circle back again either later today or tomorrow for updates - thank you! :) Also as long as we get this merged sometime this month then this should be in the clear imo to make the next official dapr 1.17 release set for January🎉
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
cicoyle
left a comment
There was a problem hiding this comment.
Hi @kgal-akl - Mind fixing the linter issues:
secretstores/akeyless/akeyless.go:28:15 typecheck undefined: akeyless
secretstores/akeyless/akeyless.go:783:105 typecheck undefined: akeyless
secretstores/akeyless/akeyless.go:844:59 typecheck undefined: akeyless
Also, please ensure that all files have the proper copyright header (see other components-contrib files for reference - top should start with :
/*
Copyright 2026 The Dapr Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
)
|
re-ran CI. thx for the updates 👍🏻 |
@cicoyle done. |
|
Thanks for the final push here 🎉 Let's ensure CI is green :) The DCO step will show you what to run to sign everything and you might need to run |
45e68cb to
b0ae247
Compare
|
Hi! 👋 try this pls also ignore unrelated failures as i can rerun those :) |
74634a0 to
88722eb
Compare
done. i see only one failure for pgsql, https://github.com/dapr/components-contrib/actions/runs/22689357591/job/65782857260#step:19:63. |
|
closing and reopening to see if that fixes whatever is up with CI not posting build status... |
|
can you pls try resolving the conflicts? 🙏 |
done |
d9093c5 to
8c05c57
Compare
Signed-off-by: kgal-akl <kobbi.g@akeyless.io>
|
@sicoyle @cicoyle i'm not sure what's going on here... i feel like i'm chasing down my own tail of lints, merge from main and conflicts that arise. every time i update from main i get a conflict, i see there's consistently a difference in |
cicoyle
left a comment
There was a problem hiding this comment.
Once the comment is addressed, then make modtidy-all or go mod tidy should be the last step.
| "sync" | ||
| "time" | ||
|
|
||
| aws "github.com/akeylesslabs/akeyless-go-cloud-id/cloudprovider/aws" |
There was a problem hiding this comment.
I pulled this down locally and there are some changes needed to get CI green that I can't push to this branch and fix myself.
aws "github.com/akeylesslabs/akeyless-go-cloud-id/cloudprovider/aws" transitively depends on aws-sdk-go v1, which is incompatible with the Go version in our go.mod (1.24.13). dapr/components-contrib has migrated to aws-sdk-go v2 as v1 was deprecated.
Could you update akeyless-go-cloud-id on your end to use aws-sdk-go v2? That should resolve the build and lint failures.
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it was marked stale with no further activity for 7 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Description
Added a new Secret Store component for Akeyless.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Issue reference
#4063
Requirements