Skip to content

Add Akeyless Secrets Store Component#4036

Closed
kgal-akl wants to merge 2 commits into
dapr:mainfrom
akeylesslabs:add-akeyless-secretstore
Closed

Add Akeyless Secrets Store Component#4036
kgal-akl wants to merge 2 commits into
dapr:mainfrom
akeylesslabs:add-akeyless-secretstore

Conversation

@kgal-akl
Copy link
Copy Markdown

@kgal-akl kgal-akl commented Sep 19, 2025

Description

Added a new Secret Store component for Akeyless.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Issue reference

#4063

Requirements

  • Code compiles correctly, component loaded successfully after compiling local daprd with added Akeyless Secret Store component, secret retrieved:
image

@kgal-akl kgal-akl mentioned this pull request Oct 4, 2025
7 tasks
@kgal-akl kgal-akl marked this pull request as ready for review October 4, 2025 05:09
@kgal-akl kgal-akl requested review from a team as code owners October 4, 2025 05:09
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/utils.go Outdated
Comment thread secretstores/akeyless/utils.go Outdated
Comment thread secretstores/akeyless/utils.go Outdated
Comment thread secretstores/akeyless/metadata.yaml
Comment thread secretstores/akeyless/metadata.yaml
Comment thread secretstores/akeyless/example.yaml Outdated
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/akeyless.go
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/akeyless.go
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/utils.go Outdated
@kgal-akl kgal-akl requested a review from sicoyle October 22, 2025 17:33
@kgal-akl kgal-akl force-pushed the add-akeyless-secretstore branch from a56fc84 to b2a72bf Compare October 22, 2025 19:17
Copy link
Copy Markdown
Contributor

@sicoyle sicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for iterating with me on this! Here's another batch of feedback for ya - I still have a bit more to review on this, but this is the main I think so far :) 🙌

Comment thread secretstores/akeyless/README.md
Comment thread secretstores/akeyless/README.md
Comment thread secretstores/akeyless/akeyless.go
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/akeyless.go
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/akeyless.go Outdated
Copy link
Copy Markdown

@tuvia-akeyless tuvia-akeyless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please verify (manually/tests) it is working for various types of dynamic and rotated secrets.

@kgal-akl

This comment was marked as outdated.

@kgal-akl kgal-akl requested a review from sicoyle November 11, 2025 18:27
@kgal-akl kgal-akl force-pushed the add-akeyless-secretstore branch 3 times, most recently from bc57bc0 to 2718c8f Compare December 1, 2025 18:38
@kgal-akl
Copy link
Copy Markdown
Author

kgal-akl commented Dec 1, 2025

@sicoyle - can you please review this again? There were a bunch of merge conflicts and it happens every I update the branch.

@kgal-akl kgal-akl force-pushed the add-akeyless-secretstore branch from 850536c to 4226c9f Compare December 9, 2025 19:33
@sicoyle
Copy link
Copy Markdown
Contributor

sicoyle commented Dec 9, 2025

@sicoyle - can you please review this again? There were a bunch of merge conflicts and it happens every I update the branch.

Hi! Yes, thank you for your patience 🙏 I've been OOO for the past two weeks on vacation. I'm back now :)

@sicoyle
Copy link
Copy Markdown
Contributor

sicoyle commented Dec 9, 2025

can you please rebase onto main? There are over 10k lines changed now in this PR with a ton of unrelated changes...

@kgal-akl kgal-akl force-pushed the add-akeyless-secretstore branch 2 times, most recently from e7bc2f8 to bb84293 Compare December 9, 2025 22:13
@kgal-akl
Copy link
Copy Markdown
Author

kgal-akl commented Dec 9, 2025

can you please rebase onto main? There are over 10k lines changed now in this PR with a ton of unrelated changes...

@sicoyle should be all cleaned up now. FYI, since your last review I added a few things:

  • Added support for authentication options for k8s, AWS IAM.
  • Added refresh token mechanism
  • Added support for filtering when bulk secret retrieval using path/secret type query params.

Copy link
Copy Markdown
Contributor

@sicoyle sicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments so far with the additions. I will circle back again either later today or tomorrow for updates - thank you! :) Also as long as we get this merged sometime this month then this should be in the clear imo to make the next official dapr 1.17 release set for January🎉

Comment thread secretstores/akeyless/README.md Outdated
Comment thread secretstores/akeyless/README.md
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/akeyless.go
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/akeyless.go
Comment thread secretstores/akeyless/akeyless.go
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/akeyless.go Outdated
Comment thread secretstores/akeyless/akeyless.go Outdated
@kgal-akl kgal-akl requested a review from sicoyle December 10, 2025 18:47
@kgal-akl
Copy link
Copy Markdown
Author

@sicoyle - I've finished going over the PR comments, let me know what you think.

Also, can you please let me know what I need to do to resolve this/(your sister's?) comment?

@kgal-akl
Copy link
Copy Markdown
Author

Hey @kgal-akl we are nearly there 🙏🏻 Could you fix DCO and the conflicts?

@sicoyle @cicoyle done.

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale label Feb 19, 2026
@kgal-akl
Copy link
Copy Markdown
Author

Hey @kgal-akl we are nearly there 🙏🏻 Could you fix DCO and the conflicts?

@sicoyle @cicoyle any updates?

@github-actions github-actions Bot removed the stale label Feb 19, 2026
Copy link
Copy Markdown
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kgal-akl - Mind fixing the linter issues:

secretstores/akeyless/akeyless.go:28:15    typecheck  undefined: akeyless
  secretstores/akeyless/akeyless.go:783:105  typecheck  undefined: akeyless
  secretstores/akeyless/akeyless.go:844:59   typecheck  undefined: akeyless

Also, please ensure that all files have the proper copyright header (see other components-contrib files for reference - top should start with :

/*
Copyright 2026 The Dapr Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
    http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

)

@kgal-akl kgal-akl requested a review from cicoyle March 4, 2026 18:42
@cicoyle
Copy link
Copy Markdown
Contributor

cicoyle commented Mar 4, 2026

re-ran CI. thx for the updates 👍🏻

@kgal-akl
Copy link
Copy Markdown
Author

kgal-akl commented Mar 4, 2026

Hi @kgal-akl - Mind fixing the linter issues:

secretstores/akeyless/akeyless.go:28:15    typecheck  undefined: akeyless
  secretstores/akeyless/akeyless.go:783:105  typecheck  undefined: akeyless
  secretstores/akeyless/akeyless.go:844:59   typecheck  undefined: akeyless

Also, please ensure that all files have the proper copyright header (see other components-contrib files for reference - top should start with :

/*
Copyright 2026 The Dapr Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
    http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

)

@cicoyle done.

@cicoyle
Copy link
Copy Markdown
Contributor

cicoyle commented Mar 4, 2026

Thanks for the final push here 🎉

Let's ensure CI is green :) The DCO step will show you what to run to sign everything and you might need to run make modtidy-all or go mod tidy

@kgal-akl kgal-akl force-pushed the add-akeyless-secretstore branch from 45e68cb to b0ae247 Compare March 4, 2026 18:46
@sicoyle
Copy link
Copy Markdown
Contributor

sicoyle commented Mar 4, 2026

Hi! 👋 try this pls


In your local branch, run: git rebase HEAD~129 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin add-akeyless-secretstore

also ignore unrelated failures as i can rerun those :)

@kgal-akl kgal-akl force-pushed the add-akeyless-secretstore branch from 74634a0 to 88722eb Compare March 4, 2026 21:36
@kgal-akl
Copy link
Copy Markdown
Author

kgal-akl commented Mar 4, 2026

Hi! 👋 try this pls


In your local branch, run: git rebase HEAD~129 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin add-akeyless-secretstore

also ignore unrelated failures as i can rerun those :)

done. i see only one failure for pgsql, https://github.com/dapr/components-contrib/actions/runs/22689357591/job/65782857260#step:19:63.

@sicoyle
Copy link
Copy Markdown
Contributor

sicoyle commented Mar 5, 2026

closing and reopening to see if that fixes whatever is up with CI not posting build status...

@sicoyle sicoyle closed this Mar 5, 2026
@sicoyle sicoyle reopened this Mar 5, 2026
@sicoyle
Copy link
Copy Markdown
Contributor

sicoyle commented Mar 5, 2026

can you pls try resolving the conflicts? 🙏

@kgal-akl
Copy link
Copy Markdown
Author

kgal-akl commented Mar 5, 2026

can you pls try resolving the conflicts? 🙏

done

Signed-off-by: Kobbi Gal <kobbi.g@akeyless.io>
@kgal-akl kgal-akl force-pushed the add-akeyless-secretstore branch from d9093c5 to 8c05c57 Compare March 6, 2026 02:36
Signed-off-by: kgal-akl <kobbi.g@akeyless.io>
@kgal-akl
Copy link
Copy Markdown
Author

kgal-akl commented Mar 6, 2026

@sicoyle @cicoyle i'm not sure what's going on here... i feel like i'm chasing down my own tail of lints, merge from main and conflicts that arise. every time i update from main i get a conflict, i see there's consistently a difference in go.{sum,mod} so i run go mod tidy and push but then it results in other lint failures. in addition, i can't seem to be able to set up the lint to run locally before pushing because it looks like it's meant to run in a CI env.

Copy link
Copy Markdown
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the comment is addressed, then make modtidy-all or go mod tidy should be the last step.

"sync"
"time"

aws "github.com/akeylesslabs/akeyless-go-cloud-id/cloudprovider/aws"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this down locally and there are some changes needed to get CI green that I can't push to this branch and fix myself.

aws "github.com/akeylesslabs/akeyless-go-cloud-id/cloudprovider/aws" transitively depends on aws-sdk-go v1, which is incompatible with the Go version in our go.mod (1.24.13). dapr/components-contrib has migrated to aws-sdk-go v2 as v1 was deprecated.

Could you update akeyless-go-cloud-id on your end to use aws-sdk-go v2? That should resolve the build and lint failures.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cicoyle thanks. opened new PR #4385 with the upgraded cloud id.

@dapr-bot
Copy link
Copy Markdown
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label Apr 15, 2026
@dapr-bot
Copy link
Copy Markdown
Collaborator

This pull request has been automatically closed because it was marked stale with no further activity for 7 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot closed this Apr 22, 2026
@kgal-akl kgal-akl deleted the add-akeyless-secretstore branch May 12, 2026 18:27
@kgal-akl kgal-akl mentioned this pull request May 12, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants